<p dir="ltr"><br>
On Oct 26, 2013 5:37 PM, "Chris Lattner" <<a href="mailto:clattner@apple.com">clattner@apple.com</a>> wrote:<br>
><br>
><br>
> On Oct 23, 2013, at 10:28 AM, Shuxin Yang <<a href="mailto:shuxin.llvm@gmail.com">shuxin.llvm@gmail.com</a>> wrote:<br>
><br>
> > Author: shuxin_yang<br>
> > Date: Wed Oct 23 12:28:19 2013<br>
> > New Revision: 193251<br>
> ><br>
> > URL: <a href="http://llvm.org/viewvc/llvm-project?rev=193251&view=rev">http://llvm.org/viewvc/llvm-project?rev=193251&view=rev</a><br>
> > Log:<br>
> > Use address-taken to disambiguate global variable and indirect memops.<br>
> ><br>
> > Major steps include:<br>
> > 1). introduces a not-addr-taken bit-field in GlobalVariable<br>
> > 2). GlobalOpt pass sets "not-address-taken" if it proves a global varirable<br>
> > dosen't have its address taken.<br>
> > 3). AA use this info for disambiguation.<br>
><br>
> Shuxin please revert this immediately.<br>
><br>
> This is a major IR change. Please propose IR changes (e.g. new bits in key datatypes) on llvmdev before making any changes like this. This is completely inappropriate for post-commit review.</p>
<p dir="ltr">He actually asked for precommit review and had a response on that thread on Tuesday. The response wasn't an LGTM tho and in no way did it look like it was done being reviewed.<br></p>
<p dir="ltr">><br>
> -Chris<br>
><br>
><br>
> ><br>
> > Added:<br>
> > llvm/trunk/test/Analysis/BasicAA/noaddrtaken.ll<br>
> > Modified:<br>
> > llvm/trunk/docs/LangRef.rst<br>
> > llvm/trunk/include/llvm/IR/GlobalVariable.h<br>
> > llvm/trunk/lib/Analysis/BasicAliasAnalysis.cpp<br>
> > llvm/trunk/lib/AsmParser/LLLexer.cpp<br>
> > llvm/trunk/lib/AsmParser/LLParser.cpp<br>
> > llvm/trunk/lib/AsmParser/LLToken.h<br>
> > llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp<br>
> > llvm/trunk/lib/Bitcode/Writer/BitcodeWriter.cpp<br>
> > llvm/trunk/lib/IR/AsmWriter.cpp<br>
> > llvm/trunk/lib/IR/Globals.cpp<br>
> > llvm/trunk/lib/Transforms/IPO/GlobalOpt.cpp<br>
> > llvm/trunk/test/Transforms/GlobalOpt/2009-03-07-PromotePtrToBool.ll<br>
> > llvm/trunk/test/Transforms/GlobalOpt/2009-11-16-MallocSingleStoreToGlobalVar.ll<br>
> > llvm/trunk/test/Transforms/GlobalOpt/atomic.ll<br>
> > llvm/trunk/test/Transforms/GlobalOpt/globalsra-unknown-index.ll<br>
> > llvm/trunk/test/Transforms/GlobalOpt/integer-bool.ll<br>
> > llvm/trunk/test/Transforms/GlobalOpt/unnamed-addr.ll<br>
> ><br>
> > Modified: llvm/trunk/docs/LangRef.rst<br>
> > URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/docs/LangRef.rst?rev=193251&r1=193250&r2=193251&view=diff">http://llvm.org/viewvc/llvm-project/llvm/trunk/docs/LangRef.rst?rev=193251&r1=193250&r2=193251&view=diff</a><br>
> > ==============================================================================<br>
> > --- llvm/trunk/docs/LangRef.rst (original)<br>
> > +++ llvm/trunk/docs/LangRef.rst Wed Oct 23 12:28:19 2013<br>
> > @@ -511,6 +511,9 @@ module, including those with external li<br>
> > ``@llvm.used``. This assumption may be suppressed by marking the<br>
> > variable with ``externally_initialized``.<br>
> ><br>
> > +If a global variable dose not have its address taken, it will be optionally<br>
> > +flagged ``notaddrtaken``.<br>
> > +<br>
> > An explicit alignment may be specified for a global, which must be a<br>
> > power of 2. If not present, or if the alignment is set to zero, the<br>
> > alignment of the global is set by the target to whatever it feels<br>
> ><br>
> > Modified: llvm/trunk/include/llvm/IR/GlobalVariable.h<br>
> > URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/IR/GlobalVariable.h?rev=193251&r1=193250&r2=193251&view=diff">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/IR/GlobalVariable.h?rev=193251&r1=193250&r2=193251&view=diff</a><br>
> > ==============================================================================<br>
> > --- llvm/trunk/include/llvm/IR/GlobalVariable.h (original)<br>
> > +++ llvm/trunk/include/llvm/IR/GlobalVariable.h Wed Oct 23 12:28:19 2013<br>
> > @@ -48,6 +48,7 @@ class GlobalVariable : public GlobalValu<br>
> > // can change from its initial<br>
> > // value before global<br>
> > // initializers are run?<br>
> > + bool notAddrTaken : 1; // Dose not have address taken.<br>
> ><br>
> > public:<br>
> > // allocate space for exactly one operand<br>
> > @@ -174,6 +175,9 @@ public:<br>
> > isExternallyInitializedConstant = Val;<br>
> > }<br>
> ><br>
> > + void setAddressMaybeTaken(bool Val) { notAddrTaken = !Val; }<br>
> > + bool AddressMaybeTaken(void) const { return !notAddrTaken; }<br>
> > +<br>
> > /// copyAttributesFrom - copy all additional attributes (those not needed to<br>
> > /// create a GlobalVariable) from the GlobalVariable Src to this one.<br>
> > void copyAttributesFrom(const GlobalValue *Src);<br>
> ><br>
> > Modified: llvm/trunk/lib/Analysis/BasicAliasAnalysis.cpp<br>
> > URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/BasicAliasAnalysis.cpp?rev=193251&r1=193250&r2=193251&view=diff">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/BasicAliasAnalysis.cpp?rev=193251&r1=193250&r2=193251&view=diff</a><br>
> > ==============================================================================<br>
> > --- llvm/trunk/lib/Analysis/BasicAliasAnalysis.cpp (original)<br>
> > +++ llvm/trunk/lib/Analysis/BasicAliasAnalysis.cpp Wed Oct 23 12:28:19 2013<br>
> > @@ -1238,6 +1238,17 @@ BasicAliasAnalysis::aliasCheck(const Val<br>
> > return NoAlias;<br>
> > if (isEscapeSource(O2) && isNonEscapingLocalObject(O1))<br>
> > return NoAlias;<br>
> > +<br>
> > + // If one object is a global variable without address taken, the other one<br>
> > + // is a different object, they will not alias because the global variable<br>
> > + // in question cannot be indirectly accessed.<br>
> > + if (const GlobalVariable *GV = dyn_cast<GlobalVariable>(O1))<br>
> > + if (!GV->AddressMaybeTaken())<br>
> > + return NoAlias;<br>
> > +<br>
> > + if (const GlobalVariable *GV = dyn_cast<GlobalVariable>(O2))<br>
> > + if (!GV->AddressMaybeTaken())<br>
> > + return NoAlias;<br>
> > }<br>
> ><br>
> > // If the size of one access is larger than the entire object on the other<br>
> ><br>
> > Modified: llvm/trunk/lib/AsmParser/LLLexer.cpp<br>
> > URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/AsmParser/LLLexer.cpp?rev=193251&r1=193250&r2=193251&view=diff">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/AsmParser/LLLexer.cpp?rev=193251&r1=193250&r2=193251&view=diff</a><br>
> > ==============================================================================<br>
> > --- llvm/trunk/lib/AsmParser/LLLexer.cpp (original)<br>
> > +++ llvm/trunk/lib/AsmParser/LLLexer.cpp Wed Oct 23 12:28:19 2013<br>
> > @@ -504,6 +504,7 @@ lltok::Kind LLLexer::LexIdentifier() {<br>
> > KEYWORD(zeroinitializer);<br>
> > KEYWORD(undef);<br>
> > KEYWORD(null);<br>
> > + KEYWORD(notaddrtaken);<br>
> > KEYWORD(to);<br>
> > KEYWORD(tail);<br>
> > KEYWORD(target);<br>
> ><br>
> > Modified: llvm/trunk/lib/AsmParser/LLParser.cpp<br>
> > URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/AsmParser/LLParser.cpp?rev=193251&r1=193250&r2=193251&view=diff">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/AsmParser/LLParser.cpp?rev=193251&r1=193250&r2=193251&view=diff</a><br>
> > ==============================================================================<br>
> > --- llvm/trunk/lib/AsmParser/LLParser.cpp (original)<br>
> > +++ llvm/trunk/lib/AsmParser/LLParser.cpp Wed Oct 23 12:28:19 2013<br>
> > @@ -704,7 +704,7 @@ bool LLParser::ParseGlobal(const std::st<br>
> > unsigned Linkage, bool HasLinkage,<br>
> > unsigned Visibility) {<br>
> > unsigned AddrSpace;<br>
> > - bool IsConstant, UnnamedAddr, IsExternallyInitialized;<br>
> > + bool IsConstant, UnnamedAddr, IsExternallyInitialized, notAddrTaken;<br>
> > GlobalVariable::ThreadLocalMode TLM;<br>
> > LocTy UnnamedAddrLoc;<br>
> > LocTy IsExternallyInitializedLoc;<br>
> > @@ -719,6 +719,7 @@ bool LLParser::ParseGlobal(const std::st<br>
> > IsExternallyInitialized,<br>
> > &IsExternallyInitializedLoc) ||<br>
> > ParseGlobalType(IsConstant) ||<br>
> > + ParseOptionalToken(lltok::kw_notaddrtaken, notAddrTaken) ||<br>
> > ParseType(Ty, TyLoc))<br>
> > return true;<br>
> ><br>
> > @@ -776,6 +777,7 @@ bool LLParser::ParseGlobal(const std::st<br>
> > GV->setLinkage((GlobalValue::LinkageTypes)Linkage);<br>
> > GV->setVisibility((GlobalValue::VisibilityTypes)Visibility);<br>
> > GV->setExternallyInitialized(IsExternallyInitialized);<br>
> > + GV->setAddressMaybeTaken(!notAddrTaken);<br>
> > GV->setThreadLocalMode(TLM);<br>
> > GV->setUnnamedAddr(UnnamedAddr);<br>
> ><br>
> ><br>
> > Modified: llvm/trunk/lib/AsmParser/LLToken.h<br>
> > URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/AsmParser/LLToken.h?rev=193251&r1=193250&r2=193251&view=diff">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/AsmParser/LLToken.h?rev=193251&r1=193250&r2=193251&view=diff</a><br>
> > ==============================================================================<br>
> > --- llvm/trunk/lib/AsmParser/LLToken.h (original)<br>
> > +++ llvm/trunk/lib/AsmParser/LLToken.h Wed Oct 23 12:28:19 2013<br>
> > @@ -51,6 +51,7 @@ namespace lltok {<br>
> > kw_localdynamic, kw_initialexec, kw_localexec,<br>
> > kw_zeroinitializer,<br>
> > kw_undef, kw_null,<br>
> > + kw_notaddrtaken,<br>
> > kw_to,<br>
> > kw_tail,<br>
> > kw_target,<br>
> ><br>
> > Modified: llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp<br>
> > URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp?rev=193251&r1=193250&r2=193251&view=diff">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp?rev=193251&r1=193250&r2=193251&view=diff</a><br>
> > ==============================================================================<br>
> > --- llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp (original)<br>
> > +++ llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp Wed Oct 23 12:28:19 2013<br>
> > @@ -1848,6 +1848,9 @@ bool BitcodeReader::ParseModule(bool Res<br>
> > new GlobalVariable(*TheModule, Ty, isConstant, Linkage, 0, "", 0,<br>
> > TLM, AddressSpace, ExternallyInitialized);<br>
> > NewGV->setAlignment(Alignment);<br>
> > + if (Record.size() > 10)<br>
> > + NewGV->setAddressMaybeTaken(Record[10]);<br>
> > +<br>
> > if (!Section.empty())<br>
> > NewGV->setSection(Section);<br>
> > NewGV->setVisibility(Visibility);<br>
> ><br>
> > Modified: llvm/trunk/lib/Bitcode/Writer/BitcodeWriter.cpp<br>
> > URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Bitcode/Writer/BitcodeWriter.cpp?rev=193251&r1=193250&r2=193251&view=diff">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Bitcode/Writer/BitcodeWriter.cpp?rev=193251&r1=193250&r2=193251&view=diff</a><br>
> > ==============================================================================<br>
> > --- llvm/trunk/lib/Bitcode/Writer/BitcodeWriter.cpp (original)<br>
> > +++ llvm/trunk/lib/Bitcode/Writer/BitcodeWriter.cpp Wed Oct 23 12:28:19 2013<br>
> > @@ -616,11 +616,13 @@ static void WriteModuleInfo(const Module<br>
> > Vals.push_back(GV->hasSection() ? SectionMap[GV->getSection()] : 0);<br>
> > if (GV->isThreadLocal() ||<br>
> > GV->getVisibility() != GlobalValue::DefaultVisibility ||<br>
> > - GV->hasUnnamedAddr() || GV->isExternallyInitialized()) {<br>
> > + GV->hasUnnamedAddr() || GV->isExternallyInitialized() ||<br>
> > + !GV->AddressMaybeTaken()) {<br>
> > Vals.push_back(getEncodedVisibility(GV));<br>
> > Vals.push_back(getEncodedThreadLocalMode(GV));<br>
> > Vals.push_back(GV->hasUnnamedAddr());<br>
> > Vals.push_back(GV->isExternallyInitialized());<br>
> > + Vals.push_back(GV->AddressMaybeTaken());<br>
> > } else {<br>
> > AbbrevToUse = SimpleGVarAbbrev;<br>
> > }<br>
> ><br>
> > Modified: llvm/trunk/lib/IR/AsmWriter.cpp<br>
> > URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/IR/AsmWriter.cpp?rev=193251&r1=193250&r2=193251&view=diff">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/IR/AsmWriter.cpp?rev=193251&r1=193250&r2=193251&view=diff</a><br>
> > ==============================================================================<br>
> > --- llvm/trunk/lib/IR/AsmWriter.cpp (original)<br>
> > +++ llvm/trunk/lib/IR/AsmWriter.cpp Wed Oct 23 12:28:19 2013<br>
> > @@ -1459,6 +1459,7 @@ void AssemblyWriter::printGlobal(const G<br>
> > if (GV->hasUnnamedAddr()) Out << "unnamed_addr ";<br>
> > if (GV->isExternallyInitialized()) Out << "externally_initialized ";<br>
> > Out << (GV->isConstant() ? "constant " : "global ");<br>
> > + if (!GV->AddressMaybeTaken()) Out << "notaddrtaken ";<br>
> > TypePrinter.print(GV->getType()->getElementType(), Out);<br>
> ><br>
> > if (GV->hasInitializer()) {<br>
> ><br>
> > Modified: llvm/trunk/lib/IR/Globals.cpp<br>
> > URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/IR/Globals.cpp?rev=193251&r1=193250&r2=193251&view=diff">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/IR/Globals.cpp?rev=193251&r1=193250&r2=193251&view=diff</a><br>
> > ==============================================================================<br>
> > --- llvm/trunk/lib/IR/Globals.cpp (original)<br>
> > +++ llvm/trunk/lib/IR/Globals.cpp Wed Oct 23 12:28:19 2013<br>
> > @@ -99,6 +99,7 @@ GlobalVariable::GlobalVariable(Type *Ty,<br>
> > }<br>
> ><br>
> > LeakDetector::addGarbageObject(this);<br>
> > + setAddressMaybeTaken(true);<br>
> > }<br>
> ><br>
> > GlobalVariable::GlobalVariable(Module &M, Type *Ty, bool constant,<br>
> > @@ -125,6 +126,7 @@ GlobalVariable::GlobalVariable(Module &M<br>
> > Before->getParent()->getGlobalList().insert(Before, this);<br>
> > else<br>
> > M.getGlobalList().push_back(this);<br>
> > + setAddressMaybeTaken(true);<br>
> > }<br>
> ><br>
> > void GlobalVariable::setParent(Module *parent) {<br>
> > @@ -185,6 +187,7 @@ void GlobalVariable::copyAttributesFrom(<br>
> > GlobalValue::copyAttributesFrom(Src);<br>
> > const GlobalVariable *SrcVar = cast<GlobalVariable>(Src);<br>
> > setThreadLocal(SrcVar->isThreadLocal());<br>
> > + setAddressMaybeTaken(SrcVar->AddressMaybeTaken());<br>
> > }<br>
> ><br>
> ><br>
> ><br>
> > Modified: llvm/trunk/lib/Transforms/IPO/GlobalOpt.cpp<br>
> > URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/IPO/GlobalOpt.cpp?rev=193251&r1=193250&r2=193251&view=diff">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/IPO/GlobalOpt.cpp?rev=193251&r1=193250&r2=193251&view=diff</a><br>
> > ==============================================================================<br>
> > --- llvm/trunk/lib/Transforms/IPO/GlobalOpt.cpp (original)<br>
> > +++ llvm/trunk/lib/Transforms/IPO/GlobalOpt.cpp Wed Oct 23 12:28:19 2013<br>
> > @@ -1723,6 +1723,7 @@ bool GlobalOpt::ProcessGlobal(GlobalVari<br>
> > if (GlobalStatus::analyzeGlobal(GV, GS))<br>
> > return false;<br>
> ><br>
> > + GV->setAddressMaybeTaken(false);<br>
> > if (!GS.IsCompared && !GV->hasUnnamedAddr()) {<br>
> > GV->setUnnamedAddr(true);<br>
> > NumUnnamed++;<br>
> ><br>
> > Added: llvm/trunk/test/Analysis/BasicAA/noaddrtaken.ll<br>
> > URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Analysis/BasicAA/noaddrtaken.ll?rev=193251&view=auto">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Analysis/BasicAA/noaddrtaken.ll?rev=193251&view=auto</a><br>
> > ==============================================================================<br>
> > --- llvm/trunk/test/Analysis/BasicAA/noaddrtaken.ll (added)<br>
> > +++ llvm/trunk/test/Analysis/BasicAA/noaddrtaken.ll Wed Oct 23 12:28:19 2013<br>
> > @@ -0,0 +1,29 @@<br>
> > +; RUN: opt < %s -basicaa -aa-eval -print-all-alias-modref-info 2>&1 | FileCheck %s<br>
> > +<br>
> > +; ModuleID = 'b.c'<br>
> > +target datalayout = "e-p:64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:64:64-f32:32:32-f64:64:64-v64:64:64-v128:128:128-a0:0:64-s0:64:64-f80:128:128-n8:16:32:64-S128"<br>
> > +target triple = "x86_64-apple-macosx10.8.0"<br>
> > +<br>
> > +; CHECK: NoAlias: i32* %p, i32* @xyz<br>
> > +<br>
> > +;@xyz = global i32 12, align 4<br>
> > +@xyz = internal unnamed_addr global notaddrtaken i32 12, align 4<br>
> > +<br>
> > +; Function Attrs: nounwind ssp uwtable<br>
> > +define i32 @foo(i32* nocapture %p, i32* nocapture %q) #0 {<br>
> > +entry:<br>
> > + %0 = load i32* @xyz, align 4, !tbaa !0<br>
> > + %inc = add nsw i32 %0, 1<br>
> > + store i32 %inc, i32* @xyz, align 4, !tbaa !0<br>
> > + store i32 1, i32* %p, align 4, !tbaa !0<br>
> > + %1 = load i32* @xyz, align 4, !tbaa !0<br>
> > + store i32 %1, i32* %q, align 4, !tbaa !0<br>
> > + ret i32 undef<br>
> > +}<br>
> > +<br>
> > +attributes #0 = { nounwind ssp uwtable "less-precise-fpmad"="false" "no-frame-pointer-elim"="true" "no-frame-pointer-elim-non-leaf" "no-infs-fp-math"="false" "no-nans-fp-math"="false" "stack-protector-buffer-size"="8" "unsafe-fp-math"="false" "use-soft-float"="false" }<br>
> > +<br>
> > +!0 = metadata !{metadata !1, metadata !1, i64 0}<br>
> > +!1 = metadata !{metadata !"int", metadata !2, i64 0}<br>
> > +!2 = metadata !{metadata !"omnipotent char", metadata !3, i64 0}<br>
> > +!3 = metadata !{metadata !"Simple C/C++ TBAA"}<br>
> ><br>
> > Modified: llvm/trunk/test/Transforms/GlobalOpt/2009-03-07-PromotePtrToBool.ll<br>
> > URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/GlobalOpt/2009-03-07-PromotePtrToBool.ll?rev=193251&r1=193250&r2=193251&view=diff">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/GlobalOpt/2009-03-07-PromotePtrToBool.ll?rev=193251&r1=193250&r2=193251&view=diff</a><br>
> > ==============================================================================<br>
> > --- llvm/trunk/test/Transforms/GlobalOpt/2009-03-07-PromotePtrToBool.ll (original)<br>
> > +++ llvm/trunk/test/Transforms/GlobalOpt/2009-03-07-PromotePtrToBool.ll Wed Oct 23 12:28:19 2013<br>
> > @@ -1,4 +1,4 @@<br>
> > -; RUN: opt < %s -globalopt -S | grep "@X = internal unnamed_addr global i32"<br>
> > +; RUN: opt < %s -globalopt -S | grep "@X = internal unnamed_addr global notaddrtaken i32"<br>
> > target datalayout = "e-p:32:32:32-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:32:64-f32:32:32-f64:32:64-v64:64:64-v128:128:128-a0:0:64-f80:128:128"<br>
> > target triple = "i386-apple-darwin7"<br>
> > @X = internal global i32* null ; <i32**> [#uses=2]<br>
> ><br>
> > Modified: llvm/trunk/test/Transforms/GlobalOpt/2009-11-16-MallocSingleStoreToGlobalVar.ll<br>
> > URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/GlobalOpt/2009-11-16-MallocSingleStoreToGlobalVar.ll?rev=193251&r1=193250&r2=193251&view=diff">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/GlobalOpt/2009-11-16-MallocSingleStoreToGlobalVar.ll?rev=193251&r1=193250&r2=193251&view=diff</a><br>
> > ==============================================================================<br>
> > --- llvm/trunk/test/Transforms/GlobalOpt/2009-11-16-MallocSingleStoreToGlobalVar.ll (original)<br>
> > +++ llvm/trunk/test/Transforms/GlobalOpt/2009-11-16-MallocSingleStoreToGlobalVar.ll Wed Oct 23 12:28:19 2013<br>
> > @@ -8,7 +8,7 @@ target datalayout = "e-p:64:64:64-i1:8:8<br>
> > target triple = "x86_64-apple-darwin10.0"<br>
> ><br>
> > @TOP = internal global i64* null ; <i64**> [#uses=2]<br>
> > -; CHECK: @TOP = internal unnamed_addr global i64* null<br>
> > +; CHECK: @TOP = internal unnamed_addr global notaddrtaken i64* null<br>
> > @channelColumns = internal global i64 0 ; <i64*> [#uses=2]<br>
> ><br>
> > ; Derived from @DescribeChannel() in yacr2<br>
> ><br>
> > Modified: llvm/trunk/test/Transforms/GlobalOpt/atomic.ll<br>
> > URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/GlobalOpt/atomic.ll?rev=193251&r1=193250&r2=193251&view=diff">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/GlobalOpt/atomic.ll?rev=193251&r1=193250&r2=193251&view=diff</a><br>
> > ==============================================================================<br>
> > --- llvm/trunk/test/Transforms/GlobalOpt/atomic.ll (original)<br>
> > +++ llvm/trunk/test/Transforms/GlobalOpt/atomic.ll Wed Oct 23 12:28:19 2013<br>
> > @@ -3,8 +3,8 @@<br>
> > @GV1 = internal global i64 1<br>
> > @GV2 = internal global i32 0<br>
> ><br>
> > -; CHECK: @GV1 = internal unnamed_addr constant i64 1<br>
> > -; CHECK: @GV2 = internal unnamed_addr global i32 0<br>
> > +; CHECK: @GV1 = internal unnamed_addr constant notaddrtaken i64 1<br>
> > +; CHECK: @GV2 = internal unnamed_addr global notaddrtaken i32 0<br>
> ><br>
> > define void @test1() {<br>
> > entry:<br>
> ><br>
> > Modified: llvm/trunk/test/Transforms/GlobalOpt/globalsra-unknown-index.ll<br>
> > URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/GlobalOpt/globalsra-unknown-index.ll?rev=193251&r1=193250&r2=193251&view=diff">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/GlobalOpt/globalsra-unknown-index.ll?rev=193251&r1=193250&r2=193251&view=diff</a><br>
> > ==============================================================================<br>
> > --- llvm/trunk/test/Transforms/GlobalOpt/globalsra-unknown-index.ll (original)<br>
> > +++ llvm/trunk/test/Transforms/GlobalOpt/globalsra-unknown-index.ll Wed Oct 23 12:28:19 2013<br>
> > @@ -1,5 +1,5 @@<br>
> > ; RUN: opt < %s -globalopt -S > %t<br>
> > -; RUN: grep "@Y = internal unnamed_addr global \[3 x [%]struct.X\] zeroinitializer" %t<br>
> > +; RUN: grep "@Y = internal unnamed_addr global notaddrtaken \[3 x [%]struct.X\] zeroinitializer" %t<br>
> > ; RUN: grep load %t | count 6<br>
> > ; RUN: grep "add i32 [%]a, [%]b" %t | count 3<br>
> ><br>
> ><br>
> > Modified: llvm/trunk/test/Transforms/GlobalOpt/integer-bool.ll<br>
> > URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/GlobalOpt/integer-bool.ll?rev=193251&r1=193250&r2=193251&view=diff">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/GlobalOpt/integer-bool.ll?rev=193251&r1=193250&r2=193251&view=diff</a><br>
> > ==============================================================================<br>
> > --- llvm/trunk/test/Transforms/GlobalOpt/integer-bool.ll (original)<br>
> > +++ llvm/trunk/test/Transforms/GlobalOpt/integer-bool.ll Wed Oct 23 12:28:19 2013<br>
> > @@ -4,7 +4,7 @@<br>
> > @G = internal addrspace(1) global i32 0<br>
> > ; CHECK: @G<br>
> > ; CHECK: addrspace(1)<br>
> > -; CHECK: global i1 false<br>
> > +; CHECK: global notaddrtaken i1 false<br>
> ><br>
> > define void @set1() {<br>
> > store i32 0, i32 addrspace(1)* @G<br>
> ><br>
> > Modified: llvm/trunk/test/Transforms/GlobalOpt/unnamed-addr.ll<br>
> > URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/GlobalOpt/unnamed-addr.ll?rev=193251&r1=193250&r2=193251&view=diff">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Transforms/GlobalOpt/unnamed-addr.ll?rev=193251&r1=193250&r2=193251&view=diff</a><br>
> > ==============================================================================<br>
> > --- llvm/trunk/test/Transforms/GlobalOpt/unnamed-addr.ll (original)<br>
> > +++ llvm/trunk/test/Transforms/GlobalOpt/unnamed-addr.ll Wed Oct 23 12:28:19 2013<br>
> > @@ -6,10 +6,10 @@<br>
> > @d = internal constant [4 x i8] c"foo\00", align 1<br>
> > @e = linkonce_odr global i32 0<br>
> ><br>
> > -; CHECK: @a = internal global i32 0, align 4<br>
> > +; CHECK: @a = internal global notaddrtaken i32 0, align 4<br>
> > ; CHECK: @b = internal global i32 0, align 4<br>
> > -; CHECK: @c = internal unnamed_addr global i32 0, align 4<br>
> > -; CHECK: @d = internal unnamed_addr constant [4 x i8] c"foo\00", align 1<br>
> > +; CHECK: @c = internal unnamed_addr global notaddrtaken i32 0, align 4<br>
> > +; CHECK: @d = internal unnamed_addr constant notaddrtaken [4 x i8] c"foo\00", align 1<br>
> > ; CHECK: @e = linkonce_odr global i32 0<br>
> ><br>
> > define i32 @get_e() {<br>
> ><br>
> ><br>
> > _______________________________________________<br>
> > llvm-commits mailing list<br>
> > <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> > <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</p>