<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";
mso-fareast-language:EN-US;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-GB" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"">Thanks for the review. I've seen Hal's question to Chris so I'll hold off on committing for now.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif"">By the way, Hal's question doesn’t appear on the phabricator web interface even though it's magic email address was CC'd.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""><o:p> </o:p></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt">
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Rafael Espíndola [mailto:rafael.espindola@gmail.com]
<br>
<b>Sent:</b> 24 October 2013 16:59<br>
<b>To:</b> reviews+D2013+public+4f36bb97834176c2@llvm-reviews.chandlerc.com<br>
<b>Cc:</b> jyasskin@gmail.com; Daniel Sanders; llvm-commits@cs.uiuc.edu<br>
<b>Subject:</b> Re: [PATCH] [bugpoint] Increase the default memory limit for subprocesses to 300MB.<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Lgtm<br>
<br>
On Thursday, October 24, 2013, Daniel Sanders wrote:<o:p></o:p></p>
<p class="MsoNormal">Hi jyasskin,<br>
<br>
Currently shared library builds (BUILD_SHARED_LIBS=ON in cmake) fail three<br>
bugpoint tests (BugPoint/remove_arguments_test.ll,<br>
BugPoint/crash-narrowfunctiontest.ll, and BugPoint/metadata.ll).<br>
<br>
If I run the bugpoint commands that llvm-lit runs with without -silence-passes<br>
I see errors such as this:<br>
opt: error while loading shared libraries: libLLVMSystemZInfo.so: failed to<br>
map segment from shared object: Cannot allocate memory<br>
<br>
It seems that the increased size of the binaries in a shared library build is<br>
causing the subprocess to exceed the 100MB memory limit. This patch therefore<br>
increases the default limit to a level at which these tests pass.<br>
<br>
<a href="http://llvm-reviews.chandlerc.com/D2013" target="_blank">http://llvm-reviews.chandlerc.com/D2013</a><br>
<br>
Files:<br>
tools/bugpoint/bugpoint.cpp<br>
<br>
Index: tools/bugpoint/bugpoint.cpp<br>
===================================================================<br>
--- tools/bugpoint/bugpoint.cpp<br>
+++ tools/bugpoint/bugpoint.cpp<br>
@@ -49,8 +49,8 @@<br>
<br>
static cl::opt<int><br>
MemoryLimit("mlimit", cl::init(-1), cl::value_desc("MBytes"),<br>
- cl::desc("Maximum amount of memory to use. 0 disables check."<br>
- " Defaults to 100MB (800MB under valgrind)."));<br>
+ cl::desc("Maximum amount of memory to use. 0 disables check."<br>
+ " Defaults to 300MB (800MB under valgrind)."));<br>
<br>
static cl::opt<bool><br>
UseValgrind("enable-valgrind",<br>
@@ -152,7 +152,7 @@<br>
if (sys::RunningOnValgrind() || UseValgrind)<br>
MemoryLimit = 800;<br>
else<br>
- MemoryLimit = 100;<br>
+ MemoryLimit = 300;<br>
}<br>
<br>
BugDriver D(argv[0], FindBugs, TimeoutValue, MemoryLimit,<o:p></o:p></p>
</div>
</div>
</body>
</html>