<div dir="rtl"><div dir="ltr">Michael,</div><div dir="ltr">you can generate ELF object and load with the ELF dynamic linker on Windows. Use -target i686-pc-mingw32-elf.</div><div dir="ltr"><br></div><div dir="ltr">Anton,</div>
<div dir="ltr">With regard to win64_alloca_dynalloca.ll, I understood from the previous discussion that _chkstk is required under Windows regardless of object format but not required for other OS, so the Mach-O condition on purpose was omitted on purpose.</div>
<div dir="ltr"><br></div><div dir="ltr">It's easy to bring back the !Subtarget->isTargetEnvMacho() condition but is it correct?</div><div dir="ltr"><br></div><div dir="ltr">I still do not understand the other test mingw-alloca.ll failure. It does not target Mach-O.</div>
<div dir="ltr"><br></div><div dir="ltr">mingw32 is COFF by default (unless -elf) so results should have been the same as before, right?</div><div dir="ltr"><br></div><div dir="ltr">Do the standard regression tests run at all under Windows? I'll try building them right now.</div>
<div dir="ltr"><br></div><div dir="ltr">I'm fairly new at this, sorry for any trouble!</div><div dir="ltr"><br></div><div dir="ltr">Yaron</div><div dir="ltr"><br></div>
</div><div class="gmail_extra"><br><br><div class="gmail_quote"><div dir="ltr">2013/10/23 Anton Korobeynikov <span dir="ltr"><<a href="mailto:anton@korobeynikov.info" target="_blank">anton@korobeynikov.info</a>></span></div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Actually, no. It looks like you changed the behavior:<br>
<br>
- if (Subtarget->isTargetCOFF() && !Subtarget->isTargetEnvMacho())<br>
+ if (Subtarget->isTargetWindows())<br>
<br>
Previously we have not emitted stack probe for x86_64-win32-macho and<br>
now we do. This looks incorrect.<br>
<br>
However, this should be caught by the standard set of regression<br>
tests.... Have you run them after the patch?<br>
<div class="HOEnZb"><div class="h5"><br>
<br>
On Thu, Oct 24, 2013 at 12:08 AM, Yaron Keren <<a href="mailto:yaron.keren@gmail.com">yaron.keren@gmail.com</a>> wrote:<br>
> Hi,<br>
><br>
> I am getting build failures for x86_64_debian, x86_64_ubuntu, s390-linux1,<br>
> ppc2-linux2.<br>
><br>
><br>
> <a href="http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-debian-fast/builds/8571" target="_blank">http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-debian-fast/builds/8571</a><br>
><br>
> <a href="http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-ubuntu-13.04/builds/8268" target="_blank">http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-ubuntu-13.04/builds/8268</a><br>
> <a href="http://lab.llvm.org:8011/builders/llvm-ppc64-linux2/builds/7807" target="_blank">http://lab.llvm.org:8011/builders/llvm-ppc64-linux2/builds/7807</a><br>
><br>
> The failing tests are:<br>
><br>
> LLVM::mingw-alloca.ll<br>
> LLVM::win64_alloca_dynalloca.ll<br>
><br>
> I think that the tests should be updated to reflect the change, right?<br>
><br>
> Yaron<br>
><br>
><br>
><br>
> 2013/10/23 Anton Korobeynikov <<a href="mailto:anton@korobeynikov.info">anton@korobeynikov.info</a>><br>
>><br>
>> LGTM<br>
>><br>
>> On Wed, Oct 23, 2013 at 10:51 PM, Yaron Keren <<a href="mailto:yaron.keren@gmail.com">yaron.keren@gmail.com</a>><br>
>> wrote:<br>
>> > Calling _chkstk is required on ELF as well as COFF on Windows. Without<br>
>> > _chkstk functions requiring large stack crash in initialization code.<br>
>> > Previous code tested for COFF format but not Mach-O and this patch<br>
>> > modifies<br>
>> > the code to test for Windows OS.<br>
>> ><br>
>> > Credits to Andrew MacPherson.<br>
>> ><br>
>> > Yaron<br>
>> ><br>
>> ><br>
>> > _______________________________________________<br>
>> > llvm-commits mailing list<br>
>> > <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
>> > <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
>> ><br>
>><br>
>><br>
>><br>
>> --<br>
>> With best regards, Anton Korobeynikov<br>
>> Faculty of Mathematics and Mechanics, Saint Petersburg State University<br>
><br>
><br>
<br>
<br>
<br>
--<br>
With best regards, Anton Korobeynikov<br>
Faculty of Mathematics and Mechanics, Saint Petersburg State University<br>
</div></div></blockquote></div><br></div>