<html>
<head>
<style><!--
.hmmessage P
{
margin:0px;
padding:0px
}
body.hmmessage
{
font-size: 12pt;
font-family:Calibri
}
--></style></head>
<body class='hmmessage'><div dir='ltr'>The loop itself would not break but the use of an negative integer as an index would break, no?<br><br><div><hr id="stopSpelling">Subject: Re: [PATCH] Changed loop variable from int to uint32_t in llvm-cov<br>From: bob.wilson@apple.com<br>Date: Tue, 22 Oct 2013 13:08:49 -0700<br>CC: llvm-commits@cs.uiuc.edu<br>To: yuchenericwu@hotmail.com<br><br>I don't think there is a real problem with overflow here because the loop exit conditions are using != comparisons. Even if the int values overflow, that should not change the behavior of those comparisons. (It would be different for less-than and greater-than comparisons.) But, I've applied your patch anyway since it makes sense to be consistent with the types used for the loop bounds. r193192<div><br><div><div>On Oct 22, 2013, at 10:52 AM, Yuchen Wu <<a href="mailto:yuchenericwu@hotmail.com">yuchenericwu@hotmail.com</a>> wrote:</div><br class="ecxApple-interchange-newline"><blockquote><div class="ecxhmmessage" style="font-size:12pt;font-family:Calibri;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;orphans:2;text-align:-webkit-auto;text-indent:0px;text-transform:none;white-space:normal;widows:2;word-spacing:0px;"><div dir="ltr">Changed a couple of loop variables in llvm-cov to uint32_t when the condition statement contains a comparison to uint32_t.</div><span><0005-Changed-index-variable-from-int-to-uint32_t.patch></span>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br></div></blockquote></div><br></div></div> </div></body>
</html>