<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Hi Logan,<br>
<br>
It seems that your version is much more advanced than mine. I
checked out your github repository and played with it a little.<br>
I have a question though: Why do you use the setAttributeItem with
OverwriteExisting=false in the emitFPU function?<br>
The GNU assembler does owerwrite it in this case.<br>
<br>
Best regards,<br>
Gabor Ballabas<br>
<br>
On 10/19/13 12:05, Logan Chien wrote:
<blockquote
cite="mid:CALQyFuAKLjwYNGVuitdoCdf1riycQKQUiu5=A-_XjsNwdZiDFQ@mail.gmail.com"
type="cite">
<div dir="ltr">
<div>
<div>
<div>Hi,<br>
<br>
</div>
Thanks for working on this. FYI, I have a
work-in-progress branch for this issue as well [1]. This
should work with most cases, including .eabi_attribute,
.fpu, and .cpu. However, since I have changed some of the
existing assembly test cases, I am still working to ensure
the change of the LLVM assembly output will not affect the
final binaries.<br>
</div>
<br>
</div>
Sincerely,<br>
Logan<br>
<br>
[1] <a moz-do-not-send="true"
href="https://github.com/loganchien/llvm/compare/master...arm-fix-eabi-attr-small">https://github.com/loganchien/llvm/compare/master...arm-fix-eabi-attr-small</a><br>
<br>
</div>
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">On Sat, Oct 19, 2013 at 3:08 AM, Rafael
Espíndola <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:rafael.espindola@gmail.com" target="_blank">rafael.espindola@gmail.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">Thank you
so much for working on this!<br>
<br>
Can AttributeEmitter be merged into the target asm streamer?
I.E. just<br>
add the MaybeSwitchVendor, EmitAttribute, EmitTextAttribute
and Finish<br>
to the target streamer.<br>
<br>
+ // Maps for ARM build attributes.<br>
+ std::map<unsigned, unsigned> AttributeMap;<br>
<br>
What is the range of these integers? There is almost
certainly a<br>
better data structure for doing this. Why is this on the
parser? Can't<br>
the parser just call EmitAttribute for very .eabi_attribute
and let<br>
the streamer handle it?<br>
<div>
<div class="h5"><br>
<br>
<br>
On 18 October 2013 09:21, Gabor Ballabas <<a
moz-do-not-send="true"
href="mailto:gaborb@inf.u-szeged.hu">gaborb@inf.u-szeged.hu</a>>
wrote:<br>
> This is a work-in-progress patch for this bug:<br>
> <a moz-do-not-send="true"
href="http://llvm.org/bugs/show_bug.cgi?id=15172"
target="_blank">http://llvm.org/bugs/show_bug.cgi?id=15172</a><br>
> This patch only handles the .eabi_attribute
directive but I can make the<br>
> .cpu, .fpu and .arch<br>
> directives work as well with a similar approach.<br>
><br>
> Best regards,<br>
> Gabor Ballabas<br>
><br>
</div>
</div>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a moz-do-not-send="true"
href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> <a moz-do-not-send="true"
href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits"
target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
><br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a moz-do-not-send="true"
href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a moz-do-not-send="true"
href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits"
target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote>
</div>
<br>
</div>
</blockquote>
<br>
</body>
</html>