<div dir="ltr">I could be wrong, but I don't think we have many casts like(this), and generally use casts (like)this.</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Oct 21, 2013 at 12:18 PM, Reid Kleckner <span dir="ltr"><<a href="mailto:reid@kleckner.net" target="_blank">reid@kleckner.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: rnk<br>
Date: Mon Oct 21 14:18:31 2013<br>
New Revision: 193106<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=193106&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=193106&view=rev</a><br>
Log:<br>
Fix the build in DIE.cpp with MSVC 2010<br>
<br>
Modified:<br>
    llvm/trunk/lib/CodeGen/AsmPrinter/DIE.cpp<br>
<br>
Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DIE.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DIE.cpp?rev=193106&r1=193105&r2=193106&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DIE.cpp?rev=193106&r1=193105&r2=193106&view=diff</a><br>

==============================================================================<br>
--- llvm/trunk/lib/CodeGen/AsmPrinter/DIE.cpp (original)<br>
+++ llvm/trunk/lib/CodeGen/AsmPrinter/DIE.cpp Mon Oct 21 14:18:31 2013<br>
@@ -34,8 +34,10 @@ using namespace llvm;<br>
 /// Profile - Used to gather unique data for the abbreviation folding set.<br>
 ///<br>
 void DIEAbbrevData::Profile(FoldingSetNodeID &ID) const {<br>
-  ID.AddInteger(Attribute);<br>
-  ID.AddInteger(Form);<br>
+  // Explicitly cast to an integer type for which FoldingSetNodeID has<br>
+  // overloads.  Otherwise MSVC 2010 thinks this call is ambiguous.<br>
+  ID.AddInteger(unsigned(Attribute));<br>
+  ID.AddInteger(unsigned(Form));<br>
 }<br>
<br>
 //===----------------------------------------------------------------------===//<br>
@@ -45,7 +47,7 @@ void DIEAbbrevData::Profile(FoldingSetNo<br>
 /// Profile - Used to gather unique data for the abbreviation folding set.<br>
 ///<br>
 void DIEAbbrev::Profile(FoldingSetNodeID &ID) const {<br>
-  ID.AddInteger(Tag);<br>
+  ID.AddInteger(unsigned(Tag));<br>
   ID.AddInteger(ChildrenFlag);<br>
<br>
   // For each attribute description.<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>