<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"><base href="x-msg://1972/"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Looks good. I'm committed it for you in svn r193134. Go ahead and send your next patch!<div><br><div><div><div>On Oct 21, 2013, at 12:43 PM, Yuchen Wu <<a href="mailto:yuchenericwu@hotmail.com">yuchenericwu@hotmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div class="hmmessage" style="font-size: 12pt; font-family: Calibri; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><div dir="ltr"><span style="font-family: Helvetica; font-size: 12px; ">I'm starting to work on fixing up llvm-cov to more closely match the output from gcov. </span><span style="font-family: Helvetica; font-size: 12px; ">This patch moves the printing of llvm-cov information out from collectLineCounts(), which should only organize the output data. It is now directly called from llvm-cov.cpp.</span><div style="font-family: Helvetica; font-size: 12px; "><br></div><div style="font-family: Helvetica; font-size: 12px; ">This is done in anticipation of subsequent changes which will pass in GCNO and GCDA filenames into the print function where it is printed similar to the gcov output.</div><div style="font-family: Helvetica; font-size: 12px; "><br></div><div style="font-family: Helvetica; font-size: 12px; "><br></div></div><span><0001-Moved-call-of-print-out-from-GCOVFile-collectLineCou.patch></span>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br></div></blockquote></div><br></div></div></body></html>