<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Can you try to find another solution that is less intrusive ? I understand that protecting terminators is important but the code has many users who may not want to pay the added cost that you are adding by allowing randomization. <div><br><div><div>On Oct 16, 2013, at 5:55 PM, Stephen James Crane <<a href="mailto:sjcrane@uci.edu">sjcrane@uci.edu</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr"><div>Hi Nadav,<br><br>I added the flag to be able to skip over inserted NOPs when traversing the MachineBasicBlock terminator list (CodeGen/MachineBasicBlock.cpp). There's probably a better way to do this, but I don't know it. Any ideas? We still wanted to insert in between terminators, since we don't want to leave anything predictably untouched.<br>
<br></div>- stephen<br></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Oct 16, 2013 at 5:50 PM, Nadav Rotem <span dir="ltr"><<a href="mailto:nrotem@apple.com" target="_blank">nrotem@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Stephen,<br>
<br>
Why did you need to add a new NOP flag and the isInsertedNOP function ?<br>
<br>
Thanks,<br>
Nadav<br>
<div><div class="h5"><br>
<br>
On Oct 16, 2013, at 5:30 PM, Stephen Crane <<a href="mailto:sjcrane@uci.edu">sjcrane@uci.edu</a>> wrote:<br>
<br>
> - Replaced OpenSSL AES RNG with an MD5 HMAC_DRBG RNG<br>
> - Updating test cases for new RNG<br>
> - Formatting and comments for the RNG<br>
><br>
> <a href="http://llvm-reviews.chandlerc.com/D1802" target="_blank">http://llvm-reviews.chandlerc.com/D1802</a><br>
><br>
> CHANGE SINCE LAST DIFF<br>
> <a href="http://llvm-reviews.chandlerc.com/D1802?vs=4930&id=4977#toc" target="_blank">http://llvm-reviews.chandlerc.com/D1802?vs=4930&id=4977#toc</a><br>
><br>
> Files:<br>
> include/llvm/CodeGen/CommandFlags.h<br>
> include/llvm/CodeGen/MachineInstr.h<br>
> include/llvm/MC/MCRegisterInfo.h<br>
> include/llvm/Support/RandomNumberGenerator.h<br>
> include/llvm/Target/TargetOptions.h<br>
> lib/CodeGen/LLVMBuild.txt<br>
> lib/CodeGen/MachineBasicBlock.cpp<br>
> lib/CodeGen/SelectionDAG/ScheduleDAGRRList.cpp<br>
> lib/LTO/LTOCodeGenerator.cpp<br>
> lib/LTO/LTOModule.cpp<br>
> lib/Support/CMakeLists.txt<br>
> lib/Support/RandomNumberGenerator.cpp<br>
> lib/Target/X86/CMakeLists.txt<br>
> lib/Target/X86/NOPInsertion.cpp<br>
> lib/Target/X86/X86.h<br>
> lib/Target/X86/X86TargetMachine.cpp<br>
> test/CodeGen/X86/nop-insert-percentage.ll<br>
> test/CodeGen/X86/nop-insert.ll<br>
> test/CodeGen/X86/sched-rnd-test.ll<br>
> tools/llc/llc.cpp<br>
> tools/llvm-lto/llvm-lto.cpp<br>
> tools/lto/lto.cpp<br>
> tools/opt/opt.cpp<br>
</div></div>> <D1802.7.patch><br>
<br>
</blockquote></div><br></div>
</blockquote></div><br></div></body></html>