<div dir="ltr"><div class="gmail_extra"><div>On Tue, Oct 15, 2013 at 3:27 PM, Rui Ueyama <span dir="ltr"><<a href="mailto:ruiu@google.com" target="_blank">ruiu@google.com</a>></span> wrote:<br></div><div class="gmail_quote">

<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr">How about windows_resource?</div></blockquote>

<div><br></div><div>Sure.</div><div><br></div><div>- Michael Spencer<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">

<div><div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Oct 15, 2013 at 3:21 PM, Michael Spencer <span dir="ltr"><<a href="mailto:bigcheesegs@gmail.com" target="_blank">bigcheesegs@gmail.com</a>></span> wrote:<br>



<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><br>
  Other than that it lgtm.<br>
<br>
<br>
================<br>
Comment at: include/llvm/Support/FileSystem.h:242<br>
@@ -242,1 +241,3 @@<br>
<div>+    pecoff_executable,        ///< PECOFF executable file<br>
+    resource,                 ///< Windows compiled resource file (.rc)<br>
   };<br>
</div>----------------<br>
I think this needs a better name. Resource is very generic.<br>
<br>
<br>
<a href="http://llvm-reviews.chandlerc.com/D1943" target="_blank">http://llvm-reviews.chandlerc.com/D1943</a><br>
<br>
BRANCH<br>
  master<br>
<br>
ARCANIST PROJECT<br>
  llvm<br>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div></div>