<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
<div class="moz-cite-prefix">On 10/14/2013 12:49 PM, Reid Kleckner
wrote:<br>
</div>
<blockquote
cite="mid:CACs=tyKv+NtLaOdhVe=Noho_CDVyd5ifsMeKkgNxv6+MKh5psg@mail.gmail.com"
type="cite">
<div dir="ltr">This seems like way overkill for something that
doesn't have a real finalizer. All threads will observe the
same page size, right? Why not query the size and do an atomic
store if the size is uninitialized? You'd probably need to
consult a shared memory expert to get this 100% correct.</div>
<div class="gmail_extra"><br>
</div>
</blockquote>
The actual use of the value is pretty light-weight. I can rewrite
this using memory fences easily enough, but is removing one
finalization call worth the maintenance cost of having a unique
implementation?<br>
<blockquote
cite="mid:CACs=tyKv+NtLaOdhVe=Noho_CDVyd5ifsMeKkgNxv6+MKh5psg@mail.gmail.com"
type="cite">
<div class="gmail_extra"><br>
<div class="gmail_quote">On Mon, Oct 14, 2013 at 9:01 AM, Jim
Kearney <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:jim.kearney@oracle.com" target="_blank">jim.kearney@oracle.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">Please
review the attached patch which is intended to fix <a
moz-do-not-send="true"
href="http://llvm.org/bugs/show_bug.cgi?id=15749"
target="_blank">http://llvm.org/bugs/show_bug.cgi?id=15749</a>.
If it's acceptable, please commit it.<br>
<br>
It replaces an auto static with a ManagedStatic<> to
eliminate a race in multithreaded code generation (on some
platforms/compilers).<br>
<br>
Thanks,<br>
J. Kearney<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a moz-do-not-send="true"
href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a moz-do-not-send="true"
href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits"
target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br>
</blockquote>
</div>
<br>
</div>
</blockquote>
<br>
</body>
</html>