<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Hi Ahmed,<div><br></div><div>Good to see you back on the mailing list!</div><div><br></div><div>I have looked only at the first patch at the moment.</div><div><br></div><div>Here are my remarks:</div><div>* I do not understand this comment.</div><div>-/// implementation.</div><div><div>+/// implementation. Destroys AsmWriterInst information.</div></div><div><br></div><div>You mean that the information hold in AsmWriterEmitter::Instructions is destroyed, right?</div><div><br></div><div>* What is the point of this refactoring?</div><div>I completely missed the point of this first refactoring.</div><div>You avoid the cost of building a CodeGenTarget several times, which is nice, but I do not see the benefits for the vector of AsmWriterInst.</div><div>This does not seems useful either for futur reference, as the field is private and there is no accessors.</div><div><span style="orphans: 2; text-align: -webkit-auto; widows: 2;"><br></span></div><div><span style="orphans: 2; text-align: -webkit-auto; widows: 2;">Thanks,</span></div><div><span style="orphans: 2; text-align: -webkit-auto; widows: 2;">-Quentin</span></div><div>
<br><div><div>On Oct 9, 2013, at 12:56 PM, Ahmed Bougacha <<a href="mailto:ahmed.bougacha@gmail.com">ahmed.bougacha@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">Hello everyone,<br><br>Here are 2 patches that prepare for upcoming additions. There<br>shouldn't be any functionality change.<br>Thanks for reviewing!<br><br>- Ahmed<br><br>----<br><br> TableGen: Refactor DAG patterns to enable parsing one pattern at a time.<br><br> utils/TableGen/CodeGenDAGPatterns.cpp | 112<br> utils/TableGen/CodeGenDAGPatterns.h | 5<br> 2 files changed, 66 insertions(+), 51 deletions(-)<br><br>----<br><br> TableGen: Refactor AsmWriterEmitter to keep AsmWriterInsts.<br><br> These used to be referenced by the CGI->AWI map (in AsmWriterEmitter), but<br> stored in a vector local to EmitPrintInstruction. Move the vector to<br> AsmWriterEmitter too.<br><br> utils/TableGen/AsmWriterEmitter.cpp | 51<br> 1 file changed, 25 insertions(+), 26 deletions(-)<br><span><0001-TableGen-Refactor-AsmWriterEmitter-to-keep-AsmWriter.patch></span><span><0002-TableGen-Refactor-DAG-patterns-to-enable-parsing-one.patch></span>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits<br></blockquote></div><br></div></body></html>