<p dir="ltr">LGTM </p>
<p dir="ltr">Cheers, <br>
Renato </p>
<div class="gmail_quote">On 4 Oct 2013 01:26, "Matthias Braun" <<a href="mailto:mbraun@apple.com">mbraun@apple.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word">A revised patch with testcase is attached.<div><br></div><div>Description: optimizeSelect sometimes folded some copies without respecting the previous operands register class.</div><div><br>
</div><div>Greetings</div><div><span style="white-space:pre-wrap">      </span>Matthias</div><div><br></div><div></div></div>
<br><div style="word-wrap:break-word"><div></div><div><br><div><div>On Oct 3, 2013, at 10:49 AM, Quentin Colombet <<a href="mailto:qcolombet@apple.com" target="_blank">qcolombet@apple.com</a>> wrote:</div><br><blockquote type="cite">
<div style="word-wrap:break-word">Hi Matthias,<div><br></div><div>I haven’t looked into the details of the patches but I have a general comment:</div><div>Could you add a test case for each case you are fixing (possibly in the same test file)?</div>
<div><br></div><div>Thanks for working on that.</div><div><br></div><div>Cheers,<br><div>
<div style="font-family:Helvetica;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:-webkit-auto;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;word-wrap:break-word">
-Quentin</div>

</div>
<br><div><div>On Oct 3, 2013, at 10:41 AM, Matthias Braun <<a href="mailto:mbraun@apple.com" target="_blank">mbraun@apple.com</a>> wrote:</div><br><blockquote type="cite">The attached 3 patches improve some cases in the ARM backend where bad code (in the sense of -verify-machineinstrs) was produced. Please review, thanks.<br>
<br>Greetings,<br><span style="white-space:pre-wrap">       </span>Matthias<br><span><ARM-do-not-add-a-regmask-for-TAILJUMPs.patch></span><span><ARM-optimizeSelect-has-to-consider-the-previous-regi.patch></span><span><ARM-preserv-undef-flag-in-pseudo-instruction-expande.patch></span>_______________________________________________<br>
llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div></blockquote></div><br></div></div><br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div>