<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">LGTM<div><br></div><div>Evan<br><div><div>On Oct 3, 2013, at 3:42 PM, Matthias Braun <<a href="mailto:mbraun@apple.com">mbraun@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><meta http-equiv="Content-Type" content="text/html charset=windows-1252"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div>Revised version with testcase.</div><div><br></div><div>Description: preserve undef flag in pseudo instruction expanders</div><div><div>Copy over the whole register machine operand instead of creating a new one</div><div>with an incomplete set of flags.</div></div><div><br></div><div>Greetings</div><div><span class="Apple-tab-span" style="white-space:pre"> </span>Matthias</div><div></div></div>
<span><ARM-preserve-undef-flag-in-pseudo-instruction-expand.patch></span><meta http-equiv="Content-Type" content="text/html charset=windows-1252"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;"><div></div><br><div><div>On Oct 3, 2013, at 10:49 AM, Quentin Colombet <<a href="mailto:qcolombet@apple.com">qcolombet@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><meta http-equiv="Content-Type" content="text/html charset=windows-1252"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Hi Matthias,<div><br></div><div>I haven’t looked into the details of the patches but I have a general comment:</div><div>Could you add a test case for each case you are fixing (possibly in the same test file)?</div><div><br></div><div>Thanks for working on that.</div><div><br></div><div>Cheers,<br><div apple-content-edited="true">
<div style="font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">-Quentin</div>
</div>
<br><div><div>On Oct 3, 2013, at 10:41 AM, Matthias Braun <<a href="mailto:mbraun@apple.com">mbraun@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">The attached 3 patches improve some cases in the ARM backend where bad code (in the sense of -verify-machineinstrs) was produced. Please review, thanks.<br><br>Greetings,<br><span class="Apple-tab-span" style="white-space:pre"> </span>Matthias<br><span><ARM-do-not-add-a-regmask-for-TAILJUMPs.patch></span><span><ARM-optimizeSelect-has-to-consider-the-previous-regi.patch></span><span><ARM-preserv-undef-flag-in-pseudo-instruction-expande.patch></span>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br></blockquote></div><br></div></div></blockquote></div><br></div>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits<br></blockquote></div><br></div></body></html>