<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Oct 2, 2013, at 10:08 AM, Bob Wilson <<a href="mailto:bob.wilson@apple.com">bob.wilson@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Oct 2, 2013, at 8:33 AM, Alexey Samsonov <<a href="mailto:samsonov@google.com">samsonov@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr"><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Oct 1, 2013 at 10:39 PM, Bob Wilson <span dir="ltr"><<a href="mailto:bob.wilson@apple.com" target="_blank">bob.wilson@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div class="im"><br>
On Oct 1, 2013, at 10:20 AM, Nick Lewycky <<a href="mailto:nlewycky@gmail.com">nlewycky@gmail.com</a>> wrote:<br>
<br>
><br>
> The optimization was "important" for some SPEC test, but I think we're past caring about that.<br>
<br>
</div>Not necessarily. Has anyone measured the impact on SPEC and other benchmarks?<br></blockquote><div><br></div><div>I'm going to submit this anyway.</div></div></div></div></blockquote><div><br></div><div>That's not very friendly. You may not care about SPEC but that doesn't mean that no one else cares.</div><br><blockquote type="cite"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"> See Reid's comment in <a href="http://llvm-reviews.chandlerc.com/D1754">http://llvm-reviews.chandlerc.com/D1754</a> - looks like this optimization has incorrect assumptions about C programs.</div></div></div></blockquote><div><br></div>The only comment I see from Reid there is this: "I missed any earlier discussion about this. Don't we want to keep this optimization, even if it's a real corner case that fires once in a blue moon? isLeakCheckerRoot() doesn't check any flags to see if any of the sanitizers are on."</div></div></blockquote><br></div><div>OK, I see the problem, and I can't think of a way to fix it.</div><div><br></div><div>But, if this hurts SPEC results, we may need to investigate alternative ways to get the same results. Since you're the one pushing this, it would have been nice if you contributed to that effort by at least providing the performance data. You could still do that now. Please do.</div></body></html>