<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div>I added a relatively small test case in PR16785, but maybe it can be reduced a little bit more, if it is converted to .ll?</div><div><br></div><div>-Dimitry</div><div><br></div><div><div>On Oct 1, 2013, at 01:25, Rafael Espíndola <<a href="mailto:rafael.espindola@gmail.com">rafael.espindola@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">Test case?<span></span><br><br>On Monday, September 30, 2013, Preston Gurd wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: pgurd<br>
Date: Mon Sep 30 18:18:42 2013<br>
New Revision: 191711<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=191711&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=191711&view=rev</a><br>
Log:<br>
The X86FixupLEAs pass for Intel Atom must not call convertToThreeAddress<br>
on ADD16rr opcodes, if src1 != src, since that would cause<br>
convertToThreeAddress to try to create a virtual register. This is not<br>
permitted after register allocation, which is when the X86FixupLEAs pass<br>
runs.<br>
<br>
This patch fixes PR16785.<br>
<br>
<br>
Modified:<br>
llvm/trunk/lib/Target/X86/X86FixupLEAs.cpp<br>
<br>
Modified: llvm/trunk/lib/Target/X86/X86FixupLEAs.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86FixupLEAs.cpp?rev=191711&r1=191710&r2=191711&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86FixupLEAs.cpp?rev=191711&r1=191710&r2=191711&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Target/X86/X86FixupLEAs.cpp (original)<br>
+++ llvm/trunk/lib/Target/X86/X86FixupLEAs.cpp Mon Sep 30 18:18:42 2013<br>
@@ -125,6 +125,14 @@ FixupLEAPass::postRAConvertToLEA(Machine<br>
// which requires isImm() to be true<br>
return 0;<br>
}<br>
+ case X86::ADD16rr:<br>
+ case X86::ADD16rr_DB:<br>
+ if (MI->getOperand(1).getReg() != MI->getOperand(2).getReg()) {<br>
+ // if src1 != src2, then convertToThreeAddress will<br>
+ // need to create a Virtual register, which we cannot do<br>
+ // after register allocation.<br>
+ return 0;<br>
+ }<br>
}<br>
return TII->convertToThreeAddress(MFI, MBBI, 0);<br>
}<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="javascript:;" onclick="_e(event, 'cvml', 'llvm-commits@cs.uiuc.edu')">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote>
_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits<br></blockquote></div><br></body></html>