<div dir="ltr">I should mention it only messed up FeatureBits and not the individual HasX bits. And almost no code uses the FeatureBits. Everything uses the HasX flags in subtarget.</div><div class="gmail_extra"><br><br><div class="gmail_quote">
On Mon, Sep 30, 2013 at 1:09 PM, Craig Topper <span dir="ltr"><<a href="mailto:craig.topper@gmail.com" target="_blank">craig.topper@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">How do you test autodetected features given that it would be on a different processor based on the buildbot pool?</div><div class="gmail_extra"><div><div class="h5"><br><br><div class="gmail_quote">On Mon, Sep 30, 2013 at 12:21 PM, Rafael Espíndola <span dir="ltr"><<a href="mailto:rafael.espindola@gmail.com" target="_blank">rafael.espindola@gmail.com</a>></span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">testcase?<br>
<br>
On 18 September 2013 01:54, Craig Topper <<a href="mailto:craig.topper@gmail.com" target="_blank">craig.topper@gmail.com</a>> wrote:<br>
> Author: ctopper<br>
> Date: Wed Sep 18 00:54:09 2013<br>
> New Revision: 190919<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=190919&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=190919&view=rev</a><br>
> Log:<br>
> Fix X86 subtarget to not overwrite the autodetected features by calling InitMCProcessorInfo right after detecting them. Instead add a new function that only updates the scheduling model and call that.<br>
><br>
> Modified:<br>
>     llvm/trunk/include/llvm/MC/MCSubtargetInfo.h<br>
>     llvm/trunk/lib/MC/MCSubtargetInfo.cpp<br>
>     llvm/trunk/lib/Target/X86/X86Subtarget.cpp<br>
><br>
> Modified: llvm/trunk/include/llvm/MC/MCSubtargetInfo.h<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/MC/MCSubtargetInfo.h?rev=190919&r1=190918&r2=190919&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/MC/MCSubtargetInfo.h?rev=190919&r1=190918&r2=190919&view=diff</a><br>


> ==============================================================================<br>
> --- llvm/trunk/include/llvm/MC/MCSubtargetInfo.h (original)<br>
> +++ llvm/trunk/include/llvm/MC/MCSubtargetInfo.h Wed Sep 18 00:54:09 2013<br>
> @@ -72,6 +72,9 @@ public:<br>
>    /// feature string). Recompute feature bits and scheduling model.<br>
>    void InitMCProcessorInfo(StringRef CPU, StringRef FS);<br>
><br>
> +  /// InitCPUSchedModel - Recompute scheduling model based on CPU.<br>
> +  void InitCPUSchedModel(StringRef CPU);<br>
> +<br>
>    /// ToggleFeature - Toggle a feature and returns the re-computed feature<br>
>    /// bits. This version does not change the implied bits.<br>
>    uint64_t ToggleFeature(uint64_t FB);<br>
><br>
> Modified: llvm/trunk/lib/MC/MCSubtargetInfo.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/MCSubtargetInfo.cpp?rev=190919&r1=190918&r2=190919&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/MCSubtargetInfo.cpp?rev=190919&r1=190918&r2=190919&view=diff</a><br>


> ==============================================================================<br>
> --- llvm/trunk/lib/MC/MCSubtargetInfo.cpp (original)<br>
> +++ llvm/trunk/lib/MC/MCSubtargetInfo.cpp Wed Sep 18 00:54:09 2013<br>
> @@ -27,6 +27,11 @@ MCSubtargetInfo::InitMCProcessorInfo(Str<br>
>    FeatureBits = Features.getFeatureBits(CPU, ProcDesc, NumProcs,<br>
>                                          ProcFeatures, NumFeatures);<br>
><br>
> +  InitCPUSchedModel(CPU);<br>
> +}<br>
> +<br>
> +void<br>
> +MCSubtargetInfo::InitCPUSchedModel(StringRef CPU) {<br>
>    if (!CPU.empty())<br>
>      CPUSchedModel = getSchedModelForCPU(CPU);<br>
>    else<br>
><br>
> Modified: llvm/trunk/lib/Target/X86/X86Subtarget.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86Subtarget.cpp?rev=190919&r1=190918&r2=190919&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86Subtarget.cpp?rev=190919&r1=190918&r2=190919&view=diff</a><br>


> ==============================================================================<br>
> --- llvm/trunk/lib/Target/X86/X86Subtarget.cpp (original)<br>
> +++ llvm/trunk/lib/Target/X86/X86Subtarget.cpp Wed Sep 18 00:54:09 2013<br>
> @@ -453,7 +453,7 @@ void X86Subtarget::resetSubtargetFeature<br>
><br>
>    // CPUName may have been set by the CPU detection code. Make sure the<br>
>    // new MCSchedModel is used.<br>
> -  InitMCProcessorInfo(CPUName, FS);<br>
> +  InitCPUSchedModel(CPUName);<br>
><br>
>    if (X86ProcFamily == IntelAtom || X86ProcFamily == IntelSLM)<br>
>      PostRAScheduler = true;<br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br><br clear="all"><div><br></div></div></div><span class="HOEnZb"><font color="#888888">-- <br>~Craig
</font></span></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br>~Craig
</div>