<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Hi,<br>
<br>
I haven't entirely been paying attention to the whole thread here,
but is there a reason we don't just call CommandLineToArgvW and
use that? Then we wouldn't have to write our own command line
parser.<br>
<br>
<pre class="moz-signature" cols="72">Richard Mitton
<a class="moz-txt-link-abbreviated" href="mailto:richard@codersnotes.com">richard@codersnotes.com</a></pre>
On 09/30/2013 05:02 PM, Reid Kleckner wrote:<br>
</div>
<blockquote
cite="mid:CACs=tyKfOqxG_3ZCO4idc7L=xO9qPDyVikPXmgynyWp=ev-OqQ@mail.gmail.com"
type="cite">
<div dir="ltr">On Mon, Sep 30, 2013 at 4:13 PM, David Majnemer <span
dir="ltr"><<a moz-do-not-send="true"
href="mailto:david.majnemer@gmail.com" target="_blank">david.majnemer@gmail.com</a>></span>
wrote:<br>
<div class="gmail_extra">
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">
<div class="im">On Mon, Sep 30, 2013 at 12:34 PM, Gao,
Yunzhong <span dir="ltr"><<a
moz-do-not-send="true"
href="mailto:yunzhong_gao@playstation.sony.com"
target="_blank">yunzhong_gao@playstation.sony.com</a>></span>
wrote:<br>
</div>
<div class="gmail_extra">
<div class="gmail_quote">
<div class="im">
<blockquote class="gmail_quote" style="margin:0 0
0 .8ex;border-left:1px #ccc
solid;padding-left:1ex">Reid's suggestion (using
wmain) does seem like a neat solution; it saves
one system-locale-to-unicode conversion.<br>
I will experiment with this approach later this
week to see how well it goes.<br>
I wonder whether the contents of a response file
should be UTF8 or system locale encoded?<br>
<span><font color="#888888">- Gao.<br>
</font></span></blockquote>
<div><br>
</div>
<div><br>
</div>
</div>
<div>I have implemented a solution that allows
mingw, cygwin and traditional win32 to allow for
unicode based paths. It will be out for review
this week. It does not use 'wmain' because that
approach has serious downsides:</div>
<div>- Doesn't work at all for cygwin</div>
<div>- Half works with mingw</div>
</div>
</div>
</div>
</blockquote>
<div><br>
</div>
<div>I discussed using GetCommandLineW() and
TokenizeWindowsCommandLine offline with David. This would
also get the original, Unicode command line and make it
UTF-8, but it requires tokenizing a Windows command line,
which we already do for response files.</div>
</div>
</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
llvm-commits mailing list
<a class="moz-txt-link-abbreviated" href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a>
<a class="moz-txt-link-freetext" href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a>
</pre>
</blockquote>
<br>
</body>
</html>