<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN">
<html><body style='font-family: Verdana,Geneva,sans-serif'>
<p>Hi Stephen,</p>
<p>The problem with the test is that QNX's grep (POSIX-compliant) doesn't find the required symbol if the file lacks a newline.</p>
<p>The extra step uses echo to ensure there is at least 1 newline in the file. The test then passes.</p>
<p>As Nick pointed out, there was a typo in the change I uploaded. The corrected diff is:</p>
<p><span style="font-family: 'andale mono', times;">Index: test/Transforms/GCOVProfiling/linkagename.ll</span><br /><span style="font-family: 'andale mono', times;">===================================================================</span><br /><span style="font-family: 'andale mono', times;">--- test/Transforms/GCOVProfiling/linkagename.ll (revision 191282)</span><br /><span style="font-family: 'andale mono', times;">+++ test/Transforms/GCOVProfiling/linkagename.ll (working copy)</span><br /><span style="font-family: 'andale mono', times;">@@ -1,7 +1,8 @@</span><br /><span style="font-family: 'andale mono', times;"> ; RUN: echo '!9 = metadata !{metadata !"%T/linkagename.ll", metadata !0}' > %t1</span><br /><span style="font-family: 'andale mono', times;"> ; RUN: cat %s %t1 > %t2</span><br /><span style="font-family: 'andale mono', times;"> ; RUN: opt -insert-gcov-profiling -disable-output < %t2</span><br /><span style="font-family: 'andale mono', times;">-; RUN: grep _Z3foov %T/linkagename.gcno</span><br /><span style="font-family: 'andale mono', times;">+; RUN: echo `cat %T/linkagename.<span style="background-color: #ffff99;">gcno</span>` >%t3</span><br /><span style="font-family: 'andale mono', times;">+; RUN: grep _Z3foov %t3</span><br /><span style="font-family: 'andale mono', times;"> ; RUN: rm %T/linkagename.gcno</span><br /> <br /><span style="font-family: 'andale mono', times;"> ; REQUIRES: shell</span></p>
<p>I'm uploading the corrected diff.</p>
<p>Thanks for your quick turnaround!</p>
<p>Thomas O'Dell</p>
<p>TR Solutions Pte Ltd</p>
<p>www.trsolutions.biz</p>
<p> </p>
<p>On 2013-09-25 13:26, Stephen Checkoway wrote:</p>
<blockquote type="cite" style="padding-left:5px; border-left:#1010ff 2px solid; margin-left:5px"><!-- html ignored --><!-- head ignored --><!-- meta ignored -->
<pre>On Sep 24, 2013, at 10:09 PM, Thomas O'Dell <<a href="mailto:thomas_odell@trsolutions.biz">thomas_odell@trsolutions.biz</a>> wrote:</pre>
<blockquote type="cite" style="padding-left:5px; border-left:#1010ff 2px solid; margin-left:5px">This is my first commit to llvm. I'm in the process of porting LLVM to X86 QNX Neutrino. I found the attached tests failed because of non-standard expectations from Unix utilities. So attached are the changes (created svn diff) that allow the tests to run.</blockquote>
<pre>
Most of these are trivial >& /dev/null to >/dev/null 2>&1 that seem obviously correct.
--- test/Transforms/GCOVProfiling/linkagename.ll (revision 191282)
+++ test/Transforms/GCOVProfiling/linkagename.ll (working copy)
@@ -1,7 +1,8 @@
; RUN: echo '!9 = metadata !{metadata !"%T/linkagename.ll", metadata !0}' > %t1
; RUN: cat %s %t1 > %t2
; RUN: opt -insert-gcov-profiling -disable-output < %t2
-; RUN: grep _Z3foov %T/linkagename.gcno
+; RUN: echo `cat %T/linkagename.gno` >%t3
+; RUN: grep _Z3foov %t3
; RUN: rm %T/linkagename.gcno
I don't really understand this one though. What's the nonstandard behavior here? In both cases, it seems to be grepping a file for _Z3foov. You've just added a new file?
</pre>
</blockquote>
<p> </p>
<div> </div>
</body></html>