<div dir="ltr">Ping.</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Sep 13, 2013 at 11:59 AM, Venkatraman Govindaraju <span dir="ltr"><<a href="mailto:venkatra@cs.wisc.edu" target="_blank">venkatra@cs.wisc.edu</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Ping.<br></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">
On Fri, Sep 6, 2013 at 9:50 AM, Venkatraman Govindaraju <span dir="ltr"><<a href="mailto:venkatra@cs.wisc.edu" target="_blank">venkatra@cs.wisc.edu</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi Rafael,<div><br></div><div> Thank you for the reviews.</div><div> Now. I split the patch into three patches.</div>
<div> First patch implements parsing and emitting .cfi_window_save and checks the binary output also. Second patch teaches AsmPrinter how to emit .cfi_register, which is required for implemening exceptionhandling for SPARC. The final patch implements ExceptionHandling support in sparc backend. </div>
<div><br></div><div> Originally I named EmitCFIGNUWIndowSave because the corresponding enum in llvm/Support/dwarf.h is DW_CFA_GNU_window_save. Now, I renamed the functions as CFIWindowSave to be consistent with the .cfi_window_save as suggested.</div>
<div><br></div><div> The EmitCFIWindowSave() and ParseCFIWindowSave() functions still start with uppercase letter to be consistent with other methods in the AsmStreamer and AsmParser class.</div><div><br></div><div>Thanks,</div>
<div>Venkatraman</div></div><div><div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, Sep 5, 2013 at 1:45 PM, Rafael Espíndola <span dir="ltr"><<a href="mailto:rafael.espindola@gmail.com" target="_blank">rafael.espindola@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Why the EmitCFIGNUWindowSave name? The other methods are named almost<br>
1:1 with the instruction. Also, please start new methods with a<br>
lowercase letter.<br>
<br>
+ case MCCFIInstruction::OpRegister:<br>
+ OutStreamer.EmitCFIRegister(Inst.getRegister(), Inst.getRegister2());<br>
+ break;<br>
<br>
Is this related?<br>
<br>
+ ExceptionsType = ExceptionHandling::DwarfCFI;<br>
<br>
Can you split this and lib/Target/Sparc/SparcFrameLowering.cpp to a<br>
followup patch? In fact, please make the first patch be just about<br>
parsing and emitting .cfi_window_save. The testcase should check the<br>
binary output too.<br>
<div><div><br>
<br>
On 1 September 2013 13:37, Venkatraman Govindaraju <<a href="mailto:venkatra@cs.wisc.edu" target="_blank">venkatra@cs.wisc.edu</a>> wrote:<br>
><br>
> Thank you for the comment. I updated the patch with support for the new CFI<br>
> directive in MC/MCParser/AsmParser.cpp.<br>
><br>
> Please let me know if it is okay to commit.<br>
><br>
> Thanks,<br>
> Venkatraman<br>
><br>
><br>
> On Thu, Aug 29, 2013 at 6:11 PM, Bill Wendling <<a href="mailto:wendling@apple.com" target="_blank">wendling@apple.com</a>> wrote:<br>
>><br>
>> Hi Venkatraman,<br>
>><br>
>> One comment, you should also add parsing support for the new CFI directive<br>
>> in lib/MC/MCParser/AsmParser.cpp.<br>
>><br>
>> -bw<br>
>><br>
>> On Aug 28, 2013, at 1:34 PM, Venkatraman Govindaraju<br>
>> <<a href="mailto:venkatra@cs.wisc.edu" target="_blank">venkatra@cs.wisc.edu</a>> wrote:<br>
>><br>
>> > Ping.<br>
>> ><br>
>> ><br>
>> > On Fri, Aug 9, 2013 at 10:57 PM, Venkatraman Govindaraju<br>
>> > <<a href="mailto:venkatra@cs.wisc.edu" target="_blank">venkatra@cs.wisc.edu</a>> wrote:<br>
>> > Please review the attached patch.<br>
>> ><br>
>> > This patch enables exception handling (using DwarfCFI) for SPARC.<br>
>> ><br>
>> > This patch also modifies MC layer so that the SPARC backend can emit<br>
>> > ".cfi_window_save" and ".cfi_register" directives, which are required for EH<br>
>> > to work correctly in SPARC.<br>
>> ><br>
>> > Thanks,<br>
>> > Venkatraman<br>
>> ><br>
>> > _______________________________________________<br>
>> > llvm-commits mailing list<br>
>> > <a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
>> > <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
>><br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
><br>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div><br></div>
</div></div></blockquote></div><br></div>