<div dir="ltr">On Wed, Sep 25, 2013 at 10:29 PM, Chandler Carruth <span dir="ltr"><<a href="mailto:chandlerc@google.com" target="_blank">chandlerc@google.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">
<div class="im">On Thu, Sep 26, 2013 at 12:22 AM, David Majnemer <span dir="ltr"><<a href="mailto:david.majnemer@gmail.com" target="_blank">david.majnemer@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Author: majnemer<br>
Date: Thu Sep 26 00:22:11 2013<br>
New Revision: 191421<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=191421&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=191421&view=rev</a><br>
Log:<br>
PPC: Do not introduce ISD nodes for fctid and fctiw<br></blockquote><div><br></div></div><div>Both a test case and an explanation for the commit log seem in order here. </div></div></div></div></blockquote><div><br></div>
<div>While we talked about this on IRC, I felt that it would be good to close the loop for those who weren't online.</div><div><br></div><div>r<span style="font-family:arial,sans-serif;font-size:13px">191419 added two ISD nodes that weren't being used. Hal Finkel ask for them to be removed, which was done in </span><font face="arial, sans-serif">r191421. It was agreed that it wasn't sensible to have a test for the change in </font><span style="font-family:arial,sans-serif">r191421.</span></div>
<div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">
<div><div class="h5"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
Modified:<br>
llvm/trunk/lib/Target/PowerPC/PPCISelLowering.h<br>
llvm/trunk/lib/Target/PowerPC/PPCInstr64Bit.td<br>
llvm/trunk/lib/Target/PowerPC/PPCInstrInfo.td<br>
<br>
Modified: llvm/trunk/lib/Target/PowerPC/PPCISelLowering.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/PowerPC/PPCISelLowering.h?rev=191421&r1=191420&r2=191421&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/PowerPC/PPCISelLowering.h?rev=191421&r1=191420&r2=191421&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Target/PowerPC/PPCISelLowering.h (original)<br>
+++ llvm/trunk/lib/Target/PowerPC/PPCISelLowering.h Thu Sep 26 00:22:11 2013<br>
@@ -42,10 +42,10 @@ namespace llvm {<br>
/// unsigned integers and single-precision outputs.<br>
FCFIDU, FCFIDS, FCFIDUS,<br>
<br>
- /// FCTI[D,W]Z? - The FCTID, FCTIDZ, FCTIW and FCTIWZ instructions,<br>
- /// taking an f32 or f64 operand, producing an f64 value containing the<br>
- /// integer representation of that FP value.<br>
- FCTID, FCTIDZ, FCTIW, FCTIWZ,<br>
+ /// FCTI[D,W]Z - The FCTIDZ and FCTIWZ instructions, taking an f32 or f64<br>
+ /// operand, producing an f64 value containing the integer representation<br>
+ /// of that FP value.<br>
+ FCTIDZ, FCTIWZ,<br>
<br>
/// Newer FCTI[D,W]UZ floating-point-to-integer conversion instructions for<br>
/// unsigned integers.<br>
<br>
Modified: llvm/trunk/lib/Target/PowerPC/PPCInstr64Bit.td<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/PowerPC/PPCInstr64Bit.td?rev=191421&r1=191420&r2=191421&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/PowerPC/PPCInstr64Bit.td?rev=191421&r1=191420&r2=191421&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Target/PowerPC/PPCInstr64Bit.td (original)<br>
+++ llvm/trunk/lib/Target/PowerPC/PPCInstr64Bit.td Thu Sep 26 00:22:11 2013<br>
@@ -970,7 +970,7 @@ defm FCFID : XForm_26r<63, 846, (outs f<br>
[(set f64:$frD, (PPCfcfid f64:$frB))]>, isPPC64;<br>
defm FCTID : XForm_26r<63, 814, (outs f8rc:$frD), (ins f8rc:$frB),<br>
"fctid", "$frD, $frB", FPGeneral,<br>
- [(set f64:$frD, (PPCfctid f64:$frB))]>, isPPC64;<br>
+ []>, isPPC64;<br>
defm FCTIDZ : XForm_26r<63, 815, (outs f8rc:$frD), (ins f8rc:$frB),<br>
"fctidz", "$frD, $frB", FPGeneral,<br>
[(set f64:$frD, (PPCfctidz f64:$frB))]>, isPPC64;<br>
<br>
Modified: llvm/trunk/lib/Target/PowerPC/PPCInstrInfo.td<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/PowerPC/PPCInstrInfo.td?rev=191421&r1=191420&r2=191421&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/PowerPC/PPCInstrInfo.td?rev=191421&r1=191420&r2=191421&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Target/PowerPC/PPCInstrInfo.td (original)<br>
+++ llvm/trunk/lib/Target/PowerPC/PPCInstrInfo.td Thu Sep 26 00:22:11 2013<br>
@@ -69,9 +69,7 @@ def PPCfcfid : SDNode<"PPCISD::FCFID",<br>
def PPCfcfidu : SDNode<"PPCISD::FCFIDU", SDTFPUnaryOp, []>;<br>
def PPCfcfids : SDNode<"PPCISD::FCFIDS", SDTFPRoundOp, []>;<br>
def PPCfcfidus: SDNode<"PPCISD::FCFIDUS", SDTFPRoundOp, []>;<br>
-def PPCfctid : SDNode<"PPCISD::FCTID", SDTFPUnaryOp, []>;<br>
def PPCfctidz : SDNode<"PPCISD::FCTIDZ", SDTFPUnaryOp, []>;<br>
-def PPCfctiw : SDNode<"PPCISD::FCTIW", SDTFPUnaryOp, []>;<br>
def PPCfctiwz : SDNode<"PPCISD::FCTIWZ", SDTFPUnaryOp, []>;<br>
def PPCfctiduz: SDNode<"PPCISD::FCTIDUZ",SDTFPUnaryOp, []>;<br>
def PPCfctiwuz: SDNode<"PPCISD::FCTIWUZ",SDTFPUnaryOp, []>;<br>
@@ -1696,7 +1694,7 @@ let Uses = [RM] in {<br>
let neverHasSideEffects = 1 in {<br>
defm FCTIW : XForm_26r<63, 14, (outs f8rc:$frD), (ins f8rc:$frB),<br>
"fctiw", "$frD, $frB", FPGeneral,<br>
- [(set f64:$frD, (PPCfctiw f64:$frB))]>;<br>
+ []>;<br>
defm FCTIWZ : XForm_26r<63, 15, (outs f8rc:$frD), (ins f8rc:$frB),<br>
"fctiwz", "$frD, $frB", FPGeneral,<br>
[(set f64:$frD, (PPCfctiwz f64:$frB))]>;<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div></div></div><br></div></div>
</blockquote></div><br></div></div>