<div dir="ltr">Do you have code size increase numbers as well?</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Sep 23, 2013 at 2:11 AM, Kostya Serebryany <span dir="ltr"><<a href="mailto:kcc@google.com" target="_blank">kcc@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi samsonov,<br>
<br>
We enable ASAN's use-after-return instrumentation at compile-time,<br>
but still keep it disabled at run-time.<br>
This enables the users to flip the flag at run-time using environment variable<br>
ASAN_OPTIONS=detect_stack_use_after_return=1 instead of using a separate build.<br>
If UAR detection is disabled at run-time, this extra compile-time instrumentation<br>
costs very small slowdown. On SPEC 2006 14 tests are not affected at all,<br>
4 tests get ~ 1% slowdown and 453.povray gets 4%.<br>
<br>
<a href="http://llvm-reviews.chandlerc.com/D1741" target="_blank">http://llvm-reviews.chandlerc.com/D1741</a><br>
<br>
Files:<br>
lib/Driver/SanitizerArgs.cpp<br>
<br>
Index: lib/Driver/SanitizerArgs.cpp<br>
===================================================================<br>
--- lib/Driver/SanitizerArgs.cpp<br>
+++ lib/Driver/SanitizerArgs.cpp<br>
@@ -211,11 +211,11 @@<br>
#define SANITIZER_GROUP(NAME, ID, ALIAS) .Case(NAME, ID)<br>
#include "clang/Basic/Sanitizers.def"<br>
.Default(SanitizeKind());<br>
- // Assume -fsanitize=address implies -fsanitize=init-order.<br>
+ // Assume -fsanitize=address implies -fsanitize=init-order,use-after-return.<br>
// FIXME: This should be either specified in Sanitizers.def, or go away when<br>
- // we get rid of "-fsanitize=init-order" flag at all.<br>
+ // we get rid of "-fsanitize=init-order,use-after-return" flags at all.<br>
if (ParsedKind & Address)<br>
- ParsedKind |= InitOrder;<br>
+ ParsedKind |= InitOrder | UseAfterReturn;<br>
return ParsedKind;<br>
}<br>
<br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div>