<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Hi Yi,<div><br></div><div>minor style nitpick:</div><div><br></div><div><div>+ if (ST->hasSSE42()) {</div><div>+ int Idx = CostTableLookup(SSE42CostTblPairWise, ISD, MTy);</div><div>+ if (Idx != -1)</div><div>+ return LT.first * SSE42CostTblPairWise[Idx].Cost;</div><div>+ }</div><div>+ }</div><div>+ else {</div><div>+ if (ST->hasAVX2()) {</div><div>+ int Idx = CostTableLookup(AVX2CostTblNoPairWise, ISD, MTy);</div><div>+ if (Idx != -1)</div><div>+ return LT.first * AVX2CostTblNoPairWise[Idx].Cost;</div><div>+ }</div><div><br></div><div>The else should be on the same line like the closing } of the preceding if.</div><div><br></div><div>Regards,</div><div><br></div><div>Tilmann</div><div><br></div><div><div>On Sep 18, 2013, at 10:50 PM, yijiang <<a href="mailto:yjiang@apple.com">yjiang@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">Hi Arnolds et al.<br><br>This patch is to polish horizontal vector reduction cost model for X86 target. Please help to review it. Thank you.<span class="Apple-converted-space"> </span><br><span><X86-costmodel.patch></span><br><br>-Yi<br>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a></div></blockquote></div><br></div></body></html>