<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Hi David, <div><br></div><div>we will round (i, i+0.5] to i and (i+0.5, i+1) to i+1. i+0.5 is really hard to tell so we just give it a slightly advantage to lower cost. <br><div><div>On Sep 18, 2013, at 2:40 PM, David Majnemer <<a href="mailto:david.majnemer@gmail.com">david.majnemer@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Sep 18, 2013 at 2:23 PM, Yi Jiang <span dir="ltr"><<a href="mailto:yjiang@apple.com" target="_blank">yjiang@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word">Hi Eric,<div><br></div><div>We use the <span style="line-height:19px;color:rgb(83,87,94)">Intel Architecture Code Analyzer to </span><font color="#53575e"><span style="line-height:19px">measure the throughput. Some operations does not occupy the port for the full cycle so there is something like 2.8. We just round it up and I will add comments to explain the background. Thank you for pointing it out. </span></font></div>
</div></blockquote><div><br></div><div>It seems like you round up 1.6 to 2 but you round 1.5 down to 1, is there a specific rationale?</div><div><br></div><div>-- </div><div>David Majnemer</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word">
<div><br></div><div>-Yi</div><div><br><div><div><div>On Sep 18, 2013, at 2:17 PM, Eric Christopher <<a href="mailto:echristo@gmail.com" target="_blank">echristo@gmail.com</a>> wrote:</div><br></div><div>
<blockquote type="cite">+ { ISD::ADD, MVT::v4i32, 3 }, // The raw data is 2.8,<br>+ { ISD::ADD, MVT::v4i64, 3 }, // Use Data from avx<br><br>These comments seem next to useless? Not sure where you've grabbed the<br>
data from or what raw data means.<br><br>Odd formatting nit:<br><br>+ { ISD::FADD, MVT::v8f32, 4 }, // Use Data from avx<br>+ { ISD::ADD, MVT::v2i64, 1 }, // The raw data is 1.5<br><br>If you're going to use multiple spaces after a , then why not line up<br>
the columns? Otherwise you may as well make it a single space :)<br><br>-eric<br><br><br>On Wed, Sep 18, 2013 at 1:50 PM, yijiang <<a href="mailto:yjiang@apple.com" target="_blank">yjiang@apple.com</a>> wrote:<br><blockquote type="cite">
Hi Arnolds et al.<br><br>This patch is to polish horizontal vector reduction cost model for X86 target. Please help to review it. Thank you.<br><br><br><br>-Yi<br><br>_______________________________________________<br>llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></blockquote></div></div><br></div></div><br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div></div>
</blockquote></div><br></div></body></html>