<div dir="ltr">You can remove mayLoad=1 and hasSideEffects=0. Instructions with patterns generate those flags automatically. Otherwise LGTM.</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Sep 16, 2013 at 8:36 AM, Ben Langmuir <span dir="ltr"><<a href="mailto:ben.langmuir@intel.com" target="_blank">ben.langmuir@intel.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">  Add tests missed in previous patch.<br>
<br>
Hi craig.topper,<br>
<br>
<a href="http://llvm-reviews.chandlerc.com/D1689" target="_blank">http://llvm-reviews.chandlerc.com/D1689</a><br>
<br>
CHANGE SINCE LAST DIFF<br>
  <a href="http://llvm-reviews.chandlerc.com/D1689?vs=4325&id=4326#toc" target="_blank">http://llvm-reviews.chandlerc.com/D1689?vs=4325&id=4326#toc</a><br>
<br>
Files:<br>
  include/llvm/IR/IntrinsicsX86.td<br>
  lib/Target/X86/X86InstrSSE.td<br>
  test/CodeGen/X86/sha.ll<br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br>~Craig
</div>