<div dir="ltr">On Fri, Sep 13, 2013 at 4:04 PM, Filip Pizlo <span dir="ltr"><<a href="mailto:fpizlo@apple.com" target="_blank">fpizlo@apple.com</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><br><div><div class="im"><div>On Sep 13, 2013, at 3:59 PM, Filip Pizlo <<a href="mailto:fpizlo@apple.com" target="_blank">fpizlo@apple.com</a>> wrote:</div>
<br><blockquote type="cite"><div style="font-size:12px;font-style:normal;font-variant:normal;font-weight:normal;letter-spacing:normal;line-height:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px">
Author: fpizlo<br>Date: Fri Sep 13 17:59:47 2013<br>New Revision: 190730<br><br>URL:<span> </span><a href="http://llvm.org/viewvc/llvm-project?rev=190730&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=190730&view=rev</a><br>
Log:<br>Make PrettyStackTraceEntry use ManagedStatic for its ThreadLocal.<br><br>This was somewhat tricky because ~PrettyStackTraceEntry() may run after<span> </span><br>llvm_shutdown() has been called. This is rare and only happens for a common idiom<span> </span><br>
used in the main() functions of command-line tools. This works around the idiom by<span> </span><br>skipping the stack clean-up if the PrettyStackTraceHead ManagedStatic is not<span> </span><br>constructed (i.e. llvm_shutdown() has been called).<br>
<br><br>Modified:<br>   llvm/trunk/include/llvm/Support/ManagedStatic.h<br>   llvm/trunk/lib/Support/PrettyStackTrace.cpp<br><br>Modified: llvm/trunk/include/llvm/Support/ManagedStatic.h<br>URL:<span> </span><a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/ManagedStatic.h?rev=190730&r1=190729&r2=190730&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/ManagedStatic.h?rev=190730&r1=190729&r2=190730&view=diff</a><br>
==============================================================================<br>--- llvm/trunk/include/llvm/Support/ManagedStatic.h (original)<br>+++ llvm/trunk/include/llvm/Support/ManagedStatic.h Fri Sep 13 17:59:47 2013<br>
@@ -99,7 +99,6 @@ public:<br>/// llvm_shutdown - Deallocate and destroy all ManagedStatic variables.<br>void llvm_shutdown();<br><br>-<br></div></blockquote><div dir="auto"><br></div></div><div dir="auto">Eek!  Sorry about that. :-/</div>
<div dir="auto"><br></div><div dir="auto">Should I revert this change in a separate changeset or should I assume that the damage is already done and be more careful next time?</div></div></div></blockquote><div><br></div>
<div>I wouldn't worry about it.</div></div></div></div>