<div dir="ltr">On Thu, Sep 12, 2013 at 1:05 PM, Shankar Easwaran <span dir="ltr"><<a href="mailto:shankare@codeaurora.org" target="_blank">shankare@codeaurora.org</a>></span> wrote:<br><div class="gmail_extra"><div class="gmail_quote">

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
  
    
  
  <div bgcolor="#FFFFFF" text="#000000">
    <div>Hi Rui,<br>
      <br>
      I think the PECOFFLinkingContext has to be derived like
      PECOFFX86_64LinkingContext and PECOFFI386_LinkingContext ?<br></div></div></blockquote><div><br></div><div>It's too early to answer to that question. At this moment it seems that PECOFFLinkingContext for x86, x86-64 and arm are not that different, so it may not worth to make them separate subclasses. If it turns out that they vary much, we may want to simplify the thing with subclasses. Adding a new class hierarchy does increase complexity, so I wouldn't do it now to avoid premature over engineering.</div>

<div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div bgcolor="#FFFFFF" text="#000000"><div>
      This would be cleaner I think.<br>
      <br>
      Thanks<br>
      <br>
      Shankar Easwaran<div><div class="h5"><br>
      <br>
      On 9/12/2013 2:57 PM, Rui Ueyama wrote:<br>
    </div></div></div>
    <blockquote type="cite"><div><div class="h5">
      <div dir="ltr">On Thu, Sep 12, 2013 at 12:23 PM, Rui Ueyama <span dir="ltr"><<a href="mailto:ruiu@google.com" target="_blank">ruiu@google.com</a>></span>
        wrote:<br>
        <div class="gmail_extra">
          <div class="gmail_quote">
            <blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
              <div dir="ltr">
                <div>Hi Joey,</div>
                <div>
                  <div>
                    <div><br>
                    </div>
                    On Thu, Sep 12, 2013 at 3:09 AM, Joey Gouly <span dir="ltr"><<a href="mailto:joey.gouly@arm.com" target="_blank">joey.gouly@arm.com</a>></span>
                    wrote:<br>
                  </div>
                </div>
                <div class="gmail_extra">
                  <div class="gmail_quote">
                    <div>
                      <div>
                        <blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Hi
                          Rui,<br>
                          <div><br>
                            > +  /// Returns the decorated name of
                            the given symbol name. On 32-bit x86,<br>
                            it<br>
                            > +  /// adds "_" at the beginning of the
                            string. On other architectures,<br>
                            the<br>
                            > +  /// return value is the same as the
                            argument.<br>
                            > +  StringRef decorateSymbol(StringRef
                            name) const {<br>
                            > +    // Because we don't support
                            architectures other than 32-bit x86,<br>
                            we'll<br>
                            > +    // prepend an underscore
                            unconditionally.<br>
                            > +    std::string str = "_";<br>
                            > +    str.append(name);<br>
                            > +    return allocateString(str);<br>
                            > +  }<br>
                            > +<br>
                            <br>
                          </div>
                          The doxygen comment and the implementation
                          don't match here. I know you said<br>
                          we only support<br>
                          32-bit x86 for now, but how hard would it be
                          to implement it correctly now?<br>
                          Or change the doxygen comment to match the
                          current implementation?<br>
                        </blockquote>
                        <div><br>
                        </div>
                      </div>
                    </div>
                    <div>The problem is that we don't have a variable
                      indicating which platform we are linking to, so we
                      can't say wether we are producing x86-32 binary or
                      not. We assume we are always creating x86-32
                      binary instead in many places... That being said,
                      it should be easy to add such variable and use it
                      here. Let me do that.</div>
                  </div>
                </div>
              </div>
            </blockquote>
          </div>
          <br>
        </div>
        <div class="gmail_extra">Done in r190628.<br>
        </div>
      </div>
      <br>
      <fieldset></fieldset>
      <br>
      </div></div><div class="im"><pre>_______________________________________________
llvm-commits mailing list
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a>
</pre>
    </div></blockquote><span class="HOEnZb"><font color="#888888">
    <br>
    <br>
    <pre cols="72">-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation</pre>
  </font></span></div>

</blockquote></div><br></div></div>