<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">Hi Rui,<br>
<br>
I think the PECOFFLinkingContext has to be derived like
PECOFFX86_64LinkingContext and PECOFFI386_LinkingContext ?<br>
<br>
This would be cleaner I think.<br>
<br>
Thanks<br>
<br>
Shankar Easwaran<br>
<br>
On 9/12/2013 2:57 PM, Rui Ueyama wrote:<br>
</div>
<blockquote
cite="mid:CAJENXgtfQXgiUi0wNdMtU690BC9QPXUXvQLOrF8j36+CCbJ=ew@mail.gmail.com"
type="cite">
<div dir="ltr">On Thu, Sep 12, 2013 at 12:23 PM, Rui Ueyama <span
dir="ltr"><<a moz-do-not-send="true"
href="mailto:ruiu@google.com" target="_blank">ruiu@google.com</a>></span>
wrote:<br>
<div class="gmail_extra">
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div dir="ltr">
<div>Hi Joey,</div>
<div>
<div class="h5">
<div><br>
</div>
On Thu, Sep 12, 2013 at 3:09 AM, Joey Gouly <span
dir="ltr"><<a moz-do-not-send="true"
href="mailto:joey.gouly@arm.com" target="_blank">joey.gouly@arm.com</a>></span>
wrote:<br>
</div>
</div>
<div class="gmail_extra">
<div class="gmail_quote">
<div>
<div class="h5">
<blockquote class="gmail_quote"
style="margin:0px 0px 0px
0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Hi
Rui,<br>
<div><br>
> + /// Returns the decorated name of
the given symbol name. On 32-bit x86,<br>
it<br>
> + /// adds "_" at the beginning of the
string. On other architectures,<br>
the<br>
> + /// return value is the same as the
argument.<br>
> + StringRef decorateSymbol(StringRef
name) const {<br>
> + // Because we don't support
architectures other than 32-bit x86,<br>
we'll<br>
> + // prepend an underscore
unconditionally.<br>
> + std::string str = "_";<br>
> + str.append(name);<br>
> + return allocateString(str);<br>
> + }<br>
> +<br>
<br>
</div>
The doxygen comment and the implementation
don't match here. I know you said<br>
we only support<br>
32-bit x86 for now, but how hard would it be
to implement it correctly now?<br>
Or change the doxygen comment to match the
current implementation?<br>
</blockquote>
<div><br>
</div>
</div>
</div>
<div>The problem is that we don't have a variable
indicating which platform we are linking to, so we
can't say wether we are producing x86-32 binary or
not. We assume we are always creating x86-32
binary instead in many places... That being said,
it should be easy to add such variable and use it
here. Let me do that.</div>
</div>
</div>
</div>
</blockquote>
</div>
<br>
</div>
<div class="gmail_extra">Done in r190628.<br>
</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
llvm-commits mailing list
<a class="moz-txt-link-abbreviated" href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a>
<a class="moz-txt-link-freetext" href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a>
</pre>
</blockquote>
<br>
<br>
<pre class="moz-signature" cols="72">--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation</pre>
</body>
</html>