<div dir="ltr">What is the change to lib/Target/X86/X86CodeEmitter.cpp doing in the patch?<div><br></div><div>The testcases seem a bit lacking... I'd like to see some tests specifically testing the new instruction.</div>

<div><br></div><div>Please send a note to llvmdev saying that this is close to being committed, with a quick description of the new instruction; I want to make sure this isn't a surprise to anyone when it gets committed.</div>
<div><br></div><div>-Eli</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Sat, Sep 7, 2013 at 9:33 AM, Michele Scandale <span dir="ltr"><<a href="mailto:michele.scandale@gmail.com" target="_blank">michele.scandale@gmail.com</a>></span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">  Removed not required forward declaration and include in AutoUpgrade.<br>
<div><br>
Hi arsenm, villmow, theraven,<br>
<br>
<a href="http://llvm-reviews.chandlerc.com/D1401" target="_blank">http://llvm-reviews.chandlerc.com/D1401</a><br>
<br>
CHANGE SINCE LAST DIFF<br>
</div>  <a href="http://llvm-reviews.chandlerc.com/D1401?vs=4102&id=4126#toc" target="_blank">http://llvm-reviews.chandlerc.com/D1401?vs=4102&id=4126#toc</a><br>
<br>
Files:<br>
  docs/LangRef.rst<br>
<div><div>  include/llvm-c/Core.h<br>
  include/llvm/AutoUpgrade.h<br>
  include/llvm/Bitcode/LLVMBitCodes.h<br>
  include/llvm/CodeGen/ISDOpcodes.h<br>
  include/llvm/CodeGen/SelectionDAG.h<br>
  include/llvm/CodeGen/SelectionDAGNodes.h<br>
  include/llvm/IR/Constants.h<br>
  include/llvm/IR/IRBuilder.h<br>
  include/llvm/IR/Instruction.def<br>
  include/llvm/IR/Instructions.h<br>
  include/llvm/InstVisitor.h<br>
  include/llvm/Target/TargetLowering.h<br>
  lib/Analysis/ConstantFolding.cpp<br>
  lib/AsmParser/LLLexer.cpp<br>
  lib/AsmParser/LLParser.cpp<br>
  lib/AsmParser/LLToken.h<br>
  lib/Bitcode/Reader/BitcodeReader.cpp<br>
  lib/Bitcode/Writer/BitcodeWriter.cpp<br>
  lib/CodeGen/SelectionDAG/SelectionDAG.cpp<br>
  lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp<br>
  lib/CodeGen/SelectionDAG/SelectionDAGBuilder.h<br>
  lib/CodeGen/SelectionDAG/SelectionDAGDumper.cpp<br>
  lib/CodeGen/TargetLoweringBase.cpp<br>
  lib/IR/AutoUpgrade.cpp<br>
  lib/IR/ConstantFold.cpp<br>
  lib/IR/Constants.cpp<br>
  lib/IR/Core.cpp<br>
  lib/IR/Instruction.cpp<br>
  lib/IR/Instructions.cpp<br>
  lib/IR/Verifier.cpp<br>
  lib/Target/NVPTX/NVPTXGenericToNVVM.cpp<br>
</div></div><div><div>  lib/Target/X86/X86CodeEmitter.cpp<br>
  lib/Target/X86/X86ISelLowering.cpp<br>
  lib/Target/X86/X86ISelLowering.h<br>
  test/CodeGen/X86/atomic-dagsched.ll<br>
  test/DebugInfo/X86/dbg-value-isel.ll<br>
  test/Other/constant-fold-gep.ll<br>
  test/Transforms/InstCombine/2009-01-16-PointerAddrSpace.ll<br>
  test/Transforms/InstCombine/2012-07-30-addrsp-bitcast.ll<br>
  test/Transforms/InstCombine/cast_ptr.ll<br>
  test/Transforms/InstCombine/constant-fold-address-space-pointer.ll<br>
  test/Transforms/InstCombine/gep-addrspace.ll<br>
  unittests/IR/InstructionsTest.cpp<br>
  utils/kate/llvm.xml<br>
  utils/vim/llvm.vim<br>
</div></div></blockquote></div><br></div></div>