<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">This looks fine.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">It would nice if we had some consistency in the use of triples since i686 and i386 are essentially synonymous. Maybe lit could normalize the triple string
before it checks the XFAIL conditions?<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">I’m not saying that you should do that now, Dimitry, just putting it out there for discussion. For now, your fix is reasonable to commit.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">-Andy<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> llvm-commits-bounces@cs.uiuc.edu [mailto:llvm-commits-bounces@cs.uiuc.edu]
<b>On Behalf Of </b>Dimitry Andric<br>
<b>Sent:</b> Friday, September 06, 2013 3:52 AM<br>
<b>To:</b> llvm-commits@cs.uiuc.edu<br>
<b>Subject:</b> [PATCH] Fix some more MCJIT PIC test XFAILs (for i386)<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt"><span style="font-size:10.0pt">Ping...<br>
<br>
Lately, I consistently got these few MCJIT test failures while building for i386-unknown-freebsd10:<br>
<br>
Failing Tests (4):<br>
LLVM :: ExecutionEngine/MCJIT/remote/test-global-init-nonzero-sm-pic.ll<br>
LLVM :: ExecutionEngine/MCJIT/remote/test-ptr-reloc-sm-pic.ll<br>
LLVM :: ExecutionEngine/MCJIT/test-global-init-nonzero-sm-pic.ll<br>
LLVM :: ExecutionEngine/MCJIT/test-ptr-reloc-sm-pic.ll<br>
<br>
These were all of the form:<br>
<br>
FAIL: LLVM :: ExecutionEngine/MCJIT/remote/test-global-init-nonzero-sm-pic.ll (38 of 71)<br>
******************** TEST 'LLVM :: ExecutionEngine/MCJIT/remote/test-global-init-nonzero-sm-pic.ll' FAILED ********************<br>
Script:<br>
--<br>
/home/dim/obj/llvm-189593M-trunk-freebsd10-i386-aconf-rel-1/Release+Asserts/bin/lli -use-mcjit -remote-mcjit -relocation-model=pic -code-model=small /share/dim/src/llvm/trunk/test/ExecutionEngine/MCJIT/remote/test-global-init-nonzero-sm-pic.ll > /dev/null<br>
--<br>
Exit Code: 1<br>
<br>
Command Output (stderr):<br>
--<br>
warning: remote mcjit does not support lazy compilation<br>
LLVM ERROR: Program used external function '_GLOBAL_OFFSET_TABLE_' which could not be resolved!<br>
<br>
--<br>
<br>
Similar to the other recent commits in this area, the 'i386' arch has to explicitly added to the XFAIL cases, as in the attached patch.<br>
<br>
This patch also changes test/lit.cfg to match 'i386' in the target_triple setting when running with mcjit, and mangling -mcjit into the target triple, which seems to be the most logical thing to do.<br>
<br>
-Dimitry<br>
<br>
P.S.: Since you theoretically can also have 'i486', 'i586' etc as part of the target triple, maybe we should also add all of these, or just fold everything into 'x86'...<o:p></o:p></span></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal"><span style="font-size:10.0pt">_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><o:p></o:p></span></p>
</div>
</div>
</div>
</body>
</html>