<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=us-ascii"><meta name=Generator content="Microsoft Word 14 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:Helvetica;
panose-1:2 11 6 4 2 2 2 2 2 4;}
@font-face
{font-family:Helvetica;
panose-1:2 11 6 4 2 2 2 2 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.MsoAcetate, li.MsoAcetate, div.MsoAcetate
{mso-style-priority:99;
mso-style-link:"Balloon Text Char";
margin:0in;
margin-bottom:.0001pt;
font-size:8.0pt;
font-family:"Tahoma","sans-serif";}
span.apple-converted-space
{mso-style-name:apple-converted-space;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.BalloonTextChar
{mso-style-name:"Balloon Text Char";
mso-style-priority:99;
mso-style-link:"Balloon Text";
font-family:"Tahoma","sans-serif";}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body lang=EN-US link=blue vlink=purple><div class=WordSection1><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>Hi Tilmann,<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal style='text-indent:.5in'><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>I’ve corrected the stylistic problems in the attached patch.<o:p></o:p></span></p><p class=MsoNormal style='text-indent:.5in'><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>Daniel<o:p></o:p></span></p><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'><o:p> </o:p></span></p><div><div style='border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in'><p class=MsoNormal><b><span style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'>From:</span></b><span style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'> Tilmann Scheller [mailto:tscheller@apple.com] <br><b>Sent:</b> Wednesday, September 04, 2013 2:06 PM<br><b>To:</b> Daniel Stewart<br><b>Cc:</b> Renato Golin; Commits<br><b>Subject:</b> Re: [PATCH] Added a new register class for Thumb PC-rel loads<o:p></o:p></span></p></div></div><p class=MsoNormal><o:p> </o:p></p><div><p class=MsoNormal>Hi Daniel,<o:p></o:p></p></div><div><p class=MsoNormal><o:p> </o:p></p></div><p class=MsoNormal>minor stylistic nitpicks:<o:p></o:p></p><div><p class=MsoNormal> - Local variables should start with an upper case letter<o:p></o:p></p></div><div><p class=MsoNormal> - cnstrn: What about a more descriptive variable name here? :)<o:p></o:p></p><div><p class=MsoNormal><o:p> </o:p></p></div><div><div><p class=MsoNormal>diff --git a/lib/Target/ARM/Thumb2InstrInfo.cpp b/lib/Target/ARM/Thumb2InstrInfo.cpp<o:p></o:p></p></div><div><p class=MsoNormal>index 286eaa0..8861eef 100644<o:p></o:p></p></div><div><p class=MsoNormal>--- a/lib/Target/ARM/Thumb2InstrInfo.cpp<o:p></o:p></p></div><div><p class=MsoNormal>+++ b/lib/Target/ARM/Thumb2InstrInfo.cpp<o:p></o:p></p></div><div><p class=MsoNormal>@@ -152,7 +152,13 @@ storeRegToStackSlot(MachineBasicBlock &MBB, MachineBasicBlock::iterator I,<o:p></o:p></p></div><div><p class=MsoNormal> // gsub_0, but needs an extra constraint for gsub_1 (which could be sp<o:p></o:p></p></div><div><p class=MsoNormal> // otherwise).<o:p></o:p></p></div><div><p class=MsoNormal> MachineRegisterInfo *MRI = &MF.getRegInfo();<o:p></o:p></p></div><div><p class=MsoNormal>- MRI->constrainRegClass(SrcReg, &ARM::GPRPair_with_gsub_1_in_rGPRRegClass);<o:p></o:p></p></div><div><p class=MsoNormal>+ const TargetRegisterClass* targetClass = TRI->getMatchingSuperRegClass(RC,<o:p></o:p></p></div><div><p class=MsoNormal>+ &ARM::rGPRRegClass,<o:p></o:p></p></div><div><p class=MsoNormal>+ ARM::gsub_1);<o:p></o:p></p></div><div><p class=MsoNormal>+ assert(targetClass && "No Matching GPRPair with gsub_1 in rGPRRegClass");<o:p></o:p></p></div><div><p class=MsoNormal>+ const TargetRegisterClass* cnstrn =<o:p></o:p></p></div><div><p class=MsoNormal>+ MRI->constrainRegClass(SrcReg, targetClass);<o:p></o:p></p></div><div><p class=MsoNormal>+ assert(cnstrn && "Couldn't constrain the register class");<o:p></o:p></p></div><div><p class=MsoNormal> <o:p></o:p></p></div><div><p class=MsoNormal> MachineInstrBuilder MIB = BuildMI(MBB, I, DL, get(ARM::t2STRDi8));<o:p></o:p></p></div><div><p class=MsoNormal> AddDReg(MIB, SrcReg, ARM::gsub_0, getKillRegState(isKill), TRI);<o:p></o:p></p></div><div><p class=MsoNormal>@@ -193,7 +199,13 @@ loadRegFromStackSlot(MachineBasicBlock &MBB, MachineBasicBlock::iterator I,<o:p></o:p></p></div><div><p class=MsoNormal> // gsub_0, but needs an extra constraint for gsub_1 (which could be sp<o:p></o:p></p></div><div><p class=MsoNormal> // otherwise).<o:p></o:p></p></div><div><p class=MsoNormal> MachineRegisterInfo *MRI = &MF.getRegInfo();<o:p></o:p></p></div><div><p class=MsoNormal>- MRI->constrainRegClass(DestReg, &ARM::GPRPair_with_gsub_1_in_rGPRRegClass);<o:p></o:p></p></div><div><p class=MsoNormal>+ const TargetRegisterClass* targetClass = TRI->getMatchingSuperRegClass(RC,<o:p></o:p></p></div><div><p class=MsoNormal>+ &ARM::rGPRRegClass,<o:p></o:p></p></div><div><p class=MsoNormal>+ ARM::gsub_1);<o:p></o:p></p></div><div><p class=MsoNormal>+ assert(targetClass && "No Matching GPRPair with gsub_1 in rGPRRegClass");<o:p></o:p></p></div><div><p class=MsoNormal>+ const TargetRegisterClass* cnstrn =<o:p></o:p></p></div><div><p class=MsoNormal>+ MRI->constrainRegClass(DestReg, targetClass);<o:p></o:p></p></div><div><p class=MsoNormal>+ assert(cnstrn && "Couldn't constrain the register class");<o:p></o:p></p></div><div><p class=MsoNormal> <o:p></o:p></p></div><div><p class=MsoNormal> MachineInstrBuilder MIB = BuildMI(MBB, I, DL, get(ARM::t2LDRDi8));<o:p></o:p></p></div><div><p class=MsoNormal> AddDReg(MIB, DestReg, ARM::gsub_0, RegState::DefineNoRead, TRI);<o:p></o:p></p></div><div><p class=MsoNormal><o:p> </o:p></p></div><div><p class=MsoNormal>Regards,<o:p></o:p></p></div><div><p class=MsoNormal><o:p> </o:p></p></div><div><p class=MsoNormal>Tilmann<o:p></o:p></p></div><div><p class=MsoNormal><o:p> </o:p></p></div><div><div><p class=MsoNormal>On Sep 4, 2013, at 5:50 PM, Daniel Stewart <<a href="mailto:stewartd@codeaurora.org">stewartd@codeaurora.org</a>> wrote:<o:p></o:p></p></div><p class=MsoNormal><br><br><o:p></o:p></p><div><div><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>Attached is the patch with the added test case. My apologies for the delay.</span><o:p></o:p></p></div><div><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'> </span><o:p></o:p></p></div><div><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>Daniel</span><o:p></o:p></p></div><div><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'> </span><o:p></o:p></p></div><div><div style='border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in'><div><p class=MsoNormal><b><span style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'>From:</span></b><span class=apple-converted-space><span style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'> </span></span><span style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'><a href="mailto:llvm-commits-bounces@cs.uiuc.edu"><span style='color:purple'>llvm-commits-bounces@cs.uiuc.edu</span></a><span class=apple-converted-space> </span>[<a href="mailto:llvm-commits-bounces@cs.uiuc.edu"><span style='color:purple'>mailto:llvm-commits-bounces@cs.uiuc.edu</span></a>]<span class=apple-converted-space> </span><b>On Behalf Of<span class=apple-converted-space> </span></b>Daniel Stewart<br><b>Sent:</b><span class=apple-converted-space> </span>Friday, August 30, 2013 4:47 PM<br><b>To:</b><span class=apple-converted-space> </span>'Renato Golin'<br><b>Cc:</b><span class=apple-converted-space> </span>'Commits'<br><b>Subject:</b><span class=apple-converted-space> </span>RE: [PATCH] Added a new register class for Thumb PC-rel loads</span><o:p></o:p></p></div></div></div><div><p class=MsoNormal> <o:p></o:p></p></div><div><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>Yes, I’ll add a test case.</span><o:p></o:p></p></div><div><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'> </span><o:p></o:p></p></div><div><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>Daniel</span><o:p></o:p></p></div><div><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'> </span><o:p></o:p></p></div><div><p class=MsoNormal><b><span style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'>From:</span></b><span class=apple-converted-space><span style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'> </span></span><span style='font-size:10.0pt;font-family:"Tahoma","sans-serif"'>Renato Golin [<a href="mailto:renato.golin@linaro.org"><span style='color:purple'>mailto:renato.golin@linaro.org</span></a>]<span class=apple-converted-space> </span><br><b>Sent:</b><span class=apple-converted-space> </span>Friday, August 30, 2013 4:43 PM<br><b>To:</b><span class=apple-converted-space> </span>Daniel Stewart<br><b>Cc:</b><span class=apple-converted-space> </span>Commits; Jim Grosbach; Evan Cheng<br><b>Subject:</b><span class=apple-converted-space> </span>Re: [PATCH] Added a new register class for Thumb PC-rel loads</span><o:p></o:p></p></div><div><p class=MsoNormal> <o:p></o:p></p></div><div><div><p class=MsoNormal>On 30 August 2013 21:14, Daniel Stewart <<a href="mailto:stewartd@codeaurora.org" target="_blank"><span style='color:purple'>stewartd@codeaurora.org</span></a>> wrote:<o:p></o:p></p></div><div><div><blockquote style='border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-top:5.0pt;margin-right:0in;margin-bottom:5.0pt'><div><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>I updated the patch per Jim’s suggestions.</span><o:p></o:p></p></div><div><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'> </span><o:p></o:p></p></div><div><p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D'>If this is acceptable, could someone commit it for me, as I do not have permissions.</span><o:p></o:p></p></div></blockquote></div><div><p class=MsoNormal> <o:p></o:p></p></div></div><div><div><p class=MsoNormal>Hi Daniel,<o:p></o:p></p></div></div><div><div><p class=MsoNormal> <o:p></o:p></p></div></div><div><div><p class=MsoNormal>Is it possible to add a test?<o:p></o:p></p></div></div><div><div><p class=MsoNormal> <o:p></o:p></p></div></div><div><div><p class=MsoNormal>cheers,<o:p></o:p></p></div></div><div><div><p class=MsoNormal>--renato<o:p></o:p></p></div></div></div><p class=MsoNormal><span style='font-size:9.0pt;font-family:"Helvetica","sans-serif"'><0001-Added-register-class-with-no-LR-used-by-PC-rel-load.patch>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu"><span style='color:purple'>llvm-commits@cs.uiuc.edu</span></a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits"><span style='color:purple'>http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</span></a><o:p></o:p></span></p></div></div><p class=MsoNormal><o:p> </o:p></p></div></div></div></body></html>