<div dir="ltr"><br><div class="gmail_extra"><div class="gmail_quote">On Tue, Sep 3, 2013 at 3:43 PM, Dmitry Vyukov <span dir="ltr"><<a href="mailto:dvyukov@google.com" target="_blank">dvyukov@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: dvyukov<br>
Date: Tue Sep  3 06:43:04 2013<br>
New Revision: 189791<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=189791&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=189791&view=rev</a><br>
Log:<br>
tsan: add suppressions for true/false positives in standard libraries<br>
<br>
Modified:<br>
    compiler-rt/trunk/lib/tsan/rtl/tsan_suppressions.cc<br>
<br>
Modified: compiler-rt/trunk/lib/tsan/rtl/tsan_suppressions.cc<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/tsan/rtl/tsan_suppressions.cc?rev=189791&r1=189790&r2=189791&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/tsan/rtl/tsan_suppressions.cc?rev=189791&r1=189790&r2=189791&view=diff</a><br>

==============================================================================<br>
--- compiler-rt/trunk/lib/tsan/rtl/tsan_suppressions.cc (original)<br>
+++ compiler-rt/trunk/lib/tsan/rtl/tsan_suppressions.cc Tue Sep  3 06:43:04 2013<br>
@@ -21,6 +21,19 @@<br>
 #include "tsan_mman.h"<br>
 #include "tsan_platform.h"<br>
<br>
+// Suppressions for true/false positives in standard libraries.<br>
+static const char *const std_suppressions =<br>
+// Libstdc++ 4.4 has data races in std::string.<br>
+// See <a href="http://crbug.com/181502" target="_blank">http://crbug.com/181502</a> for an example.<br>
+"race:^_M_rep$\n"<br>
+"race:^_M_is_leaked$\n"<br>
+<br>
+// False positive when using std <thread>.<br>
+// Happens because we miss atomic synchronization in libstdc++.<br>
+// See <a href="http://llvm.org/bugs/show_bug.cgi?id=17066" target="_blank">http://llvm.org/bugs/show_bug.cgi?id=17066</a> for details.<br>
+"race:std::_Sp_counted_ptr_inplace<std::thread::_Impl\n"<br>
+;<br></blockquote><div><br></div><div>FYI "make check-tsan" etc. complains at this dangling semicolon. I've fixed this in r189792.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

+<br>
 // Can be overriden in frontend.<br>
 #ifndef TSAN_GO<br>
 extern "C" const char *WEAK __tsan_default_suppressions() {<br>
@@ -72,6 +85,7 @@ void InitializeSuppressions() {<br>
 #ifndef TSAN_GO<br>
   supp = __tsan_default_suppressions();<br>
   g_ctx->Parse(supp);<br>
+  g_ctx->Parse(std_suppressions);<br>
 #endif<br>
 }<br>
<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div>Alexey Samsonov, MSK</div>
</div></div>