<div dir="ltr">Should be fixed by r189817.</div><div class="gmail_extra"><br><br><div class="gmail_quote">2013/9/3 Timur Iskhodzhanov <span dir="ltr"><<a href="mailto:timurrrr@google.com" target="_blank">timurrrr@google.com</a>></span><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>One left to go</div><div><br></div><div>asan_report.cc(348) : error C2220: warning treated as error - no 'object' file generated</div>
<div>asan_report.cc(348) : warning C4244: 'argument' : conversion from '__sanitizer::u64' to '__sanitizer::uptr', possible loss of data</div>
<div><br></div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">2013/9/3 Kostya Serebryany <span dir="ltr"><<a href="mailto:kcc@google.com" target="_blank">kcc@google.com</a>></span><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: kcc<br>
Date: Tue Sep 3 09:53:02 2013<br>
New Revision: 189814<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=189814&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=189814&view=rev</a><br>
Log:<br>
[asan] attemping to fix the Windows build<br>
<br>
Modified:<br>
compiler-rt/trunk/lib/asan/asan_report.cc<br>
<br>
Modified: compiler-rt/trunk/lib/asan/asan_report.cc<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/asan/asan_report.cc?rev=189814&r1=189813&r2=189814&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/asan/asan_report.cc?rev=189814&r1=189813&r2=189814&view=diff</a><br>
==============================================================================<br>
--- compiler-rt/trunk/lib/asan/asan_report.cc (original)<br>
+++ compiler-rt/trunk/lib/asan/asan_report.cc Tue Sep 3 09:53:02 2013<br>
@@ -295,13 +295,13 @@ struct StackVarDescr {<br>
uptr beg;<br>
uptr size;<br>
const char *name_pos;<br>
- s64 name_len;<br>
+ uptr name_len;<br>
};<br>
<br>
bool DescribeAddressIfStack(uptr addr, uptr access_size) {<br>
AsanThread *t = FindThreadByStackAddress(addr);<br>
if (!t) return false;<br>
- const s64 kBufSize = 4095;<br>
+ const uptr kBufSize = 4095;<br>
char buf[kBufSize];<br>
uptr offset = 0;<br>
uptr frame_pc = 0;<br>
@@ -340,19 +340,19 @@ bool DescribeAddressIfStack(uptr addr, u<br>
PrintStack(&alloca_stack);<br>
// Report the number of stack objects.<br>
char *p;<br>
- s64 n_objects = internal_simple_strtoll(frame_descr, &p, 10);<br>
+ u64 n_objects = (uptr)internal_simple_strtoll(frame_descr, &p, 10);<br>
CHECK_GT(n_objects, 0);<br>
Printf(" This frame has %zu object(s):\n", n_objects);<br>
<br>
// Report all objects in this frame.<br>
InternalScopedBuffer<StackVarDescr> vars(n_objects);<br>
- for (s64 i = 0; i < n_objects; i++) {<br>
- s64 beg, size;<br>
- s64 len;<br>
- beg = internal_simple_strtoll(p, &p, 10);<br>
- size = internal_simple_strtoll(p, &p, 10);<br>
- len = internal_simple_strtoll(p, &p, 10);<br>
- if (beg <= 0 || size <= 0 || len < 0 || *p != ' ') {<br>
+ for (uptr i = 0; i < n_objects; i++) {<br>
+ uptr beg, size;<br>
+ uptr len;<br>
+ beg = (uptr)internal_simple_strtoll(p, &p, 10);<br>
+ size = (uptr)internal_simple_strtoll(p, &p, 10);<br>
+ len = (uptr)internal_simple_strtoll(p, &p, 10);<br>
+ if (beg == 0 || size == 0 || *p != ' ') {<br>
Printf("AddressSanitizer can't parse the stack frame "<br>
"descriptor: |%s|\n", frame_descr);<br>
break;<br>
@@ -364,7 +364,7 @@ bool DescribeAddressIfStack(uptr addr, u<br>
vars[i].name_len = len;<br>
p += len;<br>
}<br>
- for (s64 i = 0; i < n_objects; i++) {<br>
+ for (uptr i = 0; i < n_objects; i++) {<br>
buf[0] = 0;<br>
internal_strncat(buf, vars[i].name_pos,<br>
static_cast<uptr>(Min(kBufSize, vars[i].name_len)));<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>