<html><head><meta http-equiv="Content-Type" content="text/html charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Hi Yi, <div><br></div><div>Thanks for working on this. Please don’t commit the whitespace changes. Everything else LGTM. </div><div><br></div><div>Thanks,</div><div>Nadav</div><div><br></div><div><br><div><div>On Sep 2, 2013, at 10:58 AM, yijiang <<a href="mailto:yjiang@apple.com">yjiang@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><meta http-equiv="Content-Type" content="text/html charset=us-ascii"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div>Hi Nadav,</div><div><br></div><div>Thank you for the comments. I have removed the flag and adjust the test cases. </div><div></div></div><span><slpnew.patch></span><meta http-equiv="Content-Type" content="text/html charset=utf-8"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div></div><br><div><div>On Aug 30, 2013, at 9:45 PM, Nadav Rotem <<a href="mailto:nrotem@apple.com">nrotem@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><meta http-equiv="Content-Type" content="text/html charset=utf-8"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Hi Yi, <div><br></div><div>Please don’t add the new flag “-slp-vec-reg-size”. This is not something that we want to control via flags. You can test the new feature just by testing <4 x float> and <5 x float> sequences. </div><div><br></div><div>Thanks,</div><div>Nadav</div><div><br><div><div>On Aug 30, 2013, at 4:30 PM, yijiang <<a href="mailto:yjiang@apple.com">yjiang@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><meta http-equiv="Content-Type" content="text/html charset=us-ascii"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Thank you guys! Here is the new patch: </div>
<span><slp.patch></span><meta http-equiv="Content-Type" content="text/html charset=utf-8"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Aug 30, 2013, at 3:37 PM, Chandler Carruth <<a href="mailto:chandlerc@google.com">chandlerc@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div dir="ltr">Try out clang-format to automatically get some (most?) of these formatting fixes? It even has a tool to run it over a patch file.</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Aug 30, 2013 at 3:28 PM, Yi Jiang <span dir="ltr"><<a href="mailto:yjiang@apple.com" target="_blank">yjiang@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Thank you for the comments. Sorry I somehow lost the version with changed format. I will do it again.<br>
Actually now the rgb_phi.ll is not enabled, so let me merge five roots_pill.ll and phi.ll<br>
<div class="HOEnZb"><div class="h5"><br>
On Aug 30, 2013, at 3:26 PM, Arnold Schwaighofer <<a href="mailto:aschwaighofer@apple.com">aschwaighofer@apple.com</a>> wrote:<br>
<br>
> Also, please remove the brackets here:<br>
><br>
> + if (i + VF > e) {<br>
> + OpsWidth = e - i;<br>
> + }<br>
> + else {<br>
> + OpsWidth = VF;<br>
> + }<br>
><br>
><br>
> Thanks,<br>
> Arnold<br>
><br>
> On Aug 30, 2013, at 5:21 PM, Arnold Schwaighofer <<a href="mailto:aschwaighofer@apple.com">aschwaighofer@apple.com</a>> wrote:<br>
><br>
>> Hi Yi,<br>
>><br>
>> Code looks good to me. The patch has some whitespace errors. Please fix these. Also “return Changed” is not intended properly.<br>
>><br>
>> Can you merge “rgb_phi.ll” “fiveroots_phi.ll” and “phi.ll” into one file?<br>
>><br>
>><br>
>> Thanks,<br>
>> Arnold<br>
>><br>
>><br>
>> On Aug 30, 2013, at 3:14 PM, Yi Jiang <<a href="mailto:yjiang@apple.com">yjiang@apple.com</a>> wrote:<br>
>><br>
>>> Hi,<br>
>>><br>
>>> In this patch we are trying to do two things:<br>
>>> 1) If the width of vectorization list candidate is bigger than vector reg width, we will break it down to fit the vector reg.<br>
>>> 2) We do not vectorize the width which is not power of two.<br>
>>><br>
>>> Here is the performance result of the change and we use ref input. Any comments and suggestions are appreciated.<br>
>>><br>
>>><br>
>>><br>
>>> Performance Regressions - Execution Time Δ Previous Current σ Δ (B) σ (B)<br>
>>> External/SPEC/CINT95/134_perl/134_perl 2.76% 2.9533 3.0348 0.0024 0.00% 0.0024<br>
>>><br>
>>><br>
>>> Performance Improvements - Execution Time Δ Previous Current σ Δ (B) σ (B)<br>
>>> External/SPEC/CFP2000/177_mesa/177_mesa -6.97% 21.1910 19.7130 0.0223 0.00% 0.0223<br>
>>> SingleSource/Benchmarks/BenchmarkGame/partialsums -5.19% 0.2969 0.2815 - 0.00% -<br>
>>> External/SPEC/CFP2000/188_ammp/188_ammp -1.54% 88.2623 86.9050 0.0823 0.00% 0.0823<br>
>>><br>
>>><br>
>>><br>
>>><br>
>>>><br>
>>> <slp.patch><br>
>>><br>
>>> _______________________________________________<br>
>>> llvm-commits mailing list<br>
>>> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
>>> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
>><br>
>><br>
>> _______________________________________________<br>
>> llvm-commits mailing list<br>
>> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
>> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
><br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br></div>
</blockquote></div><br></div>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br></blockquote></div><br></div></div></blockquote></div><br></div></blockquote></div><br></div></body></html>