<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Yup, it was already committed in r188936. I fixed the style in r189526 as you suggested.<div><br></div><div>Thanks</div><div><br></div><div>-Juergen<br><div><br><div><div><div>On Aug 28, 2013, at 3:20 PM, Eric Christopher <<a href="mailto:echristo@gmail.com">echristo@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">Haven't looked to see if it was ever committed (it also LGTM and<br>awesome for the better comments), one style nit:<br><br>+ if (Ptr->getOperand(1)->getOpcode() == ISD::MUL) {<br>+ return BaseIndexOffset(Ptr, SDValue(), 0, IsIndexSignExt);<br>+ }<br><br>No need for braces here I don't think.<br><br>-eric<br><br><br>On Wed, Aug 21, 2013 at 2:44 PM, Juergen Ributzka <<a href="mailto:juergen@apple.com">juergen@apple.com</a>> wrote:<br><blockquote type="cite">Hi @ll,<br><br>the small utility function that pattern matches Base + Index + Offset patterns for loads and stores fails to recognize the base pointer for loads/stores from/into an array at offset 0 inside a loop. As a result DAGCombiner::MergeConsecutiveStores was not able to merge all stores.<br><br>Example:<br>for(int i=0; i <N; i+=4) {<br> a[i+0] = 1;<br> a[i+1] = 1;<br> a[i+2] = 1;<br> a[i+3] = 1;<br>}<br><br>In this example BaseIndexOffset::match would identify a different base pointer for a[i+0] then for all the others.<br><br>This small patch adds an additional pattern match to recognize this special case and a test case.<br><br>Cheers,<br>Juergen<br><br><br>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a></blockquote></div></blockquote></div><br></div></div></div></body></html>