<p dir="ltr"><br>
On Aug 24, 2013 4:59 AM, "Benjamin Kramer" <<a href="mailto:benny.kra@googlemail.com">benny.kra@googlemail.com</a>> wrote:<br>
><br>
> Author: d0k<br>
> Date: Sat Aug 24 06:55:49 2013<br>
> New Revision: 189167<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=189167&view=rev">http://llvm.org/viewvc/llvm-project?rev=189167&view=rev</a><br>
> Log:<br>
> DwarfDebug: Delete orphaned children.</p>
<p dir="ltr">Thanks Ben</p>
<p dir="ltr">><br>
> Leak found by valgrind.</p>
<p dir="ltr">Was this showing up on any buildbots we should've been paying attention to?</p>
<p dir="ltr">><br>
> Modified:<br>
>     llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp<br>
><br>
> Modified: llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp?rev=189167&r1=189166&r2=189167&view=diff">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp?rev=189167&r1=189166&r2=189167&view=diff</a><br>

> ==============================================================================<br>
> --- llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp (original)<br>
> +++ llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp Sat Aug 24 06:55:49 2013<br>
> @@ -639,7 +639,10 @@ DIE *DwarfDebug::constructScopeDIE(Compi<br>
>        constructImportedEntityDIE(TheCU, i->second, ScopeDIE);<br>
>    }<br>
><br>
> -  if (!ScopeDIE) return NULL;<br>
> +  if (!ScopeDIE) {<br>
> +    std::for_each(Children.begin(), Children.end(), deleter<DIE>);<br>
> +    return NULL;<br>
> +  }<br>
><br>
>    // Add children<br>
>    for (SmallVectorImpl<DIE *>::iterator I = Children.begin(),<br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</p>