<html dir="ltr">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=Windows-1252">
<style>
<!--
@font-face
{font-family:Calibri}
@font-face
{font-family:Tahoma}
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif"}
a:link, span.MsoHyperlink
{color:blue;
text-decoration:underline}
a:visited, span.MsoHyperlinkFollowed
{color:purple;
text-decoration:underline}
p
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif"}
p.MsoAcetate, li.MsoAcetate, div.MsoAcetate
{margin:0cm;
margin-bottom:.0001pt;
font-size:8.0pt;
font-family:"Tahoma","sans-serif"}
span.BalloonTextChar
{font-family:"Tahoma","sans-serif"}
p.msochpdefault, li.msochpdefault, div.msochpdefault
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Calibri","sans-serif"}
span.emailstyle17
{font-family:"Calibri","sans-serif";
color:windowtext}
span.EmailStyle22
{font-family:"Calibri","sans-serif";
color:windowtext}
span.EmailStyle23
{font-family:"Calibri","sans-serif";
color:windowtext}
.MsoChpDefault
{font-size:10.0pt}
@page WordSection1
{margin:72.0pt 72.0pt 72.0pt 72.0pt}
-->
</style><style id="owaParaStyle" type="text/css">P {margin-top:0;margin-bottom:0;}</style>
</head>
<body ocsi="0" fpstyle="1" lang="EN-GB" link="blue" vlink="purple">
<div style="direction: ltr;font-family: Tahoma;color: #000000;font-size: 10pt;">Ok, works for me as well now.<br>
<br>
LGTM<br>
<br>
Jack<br>
<div style="font-family: Times New Roman; color: #000000; font-size: 16px">
<hr tabindex="-1">
<div style="direction: ltr;" id="divRpF296325"><font color="#000000" face="Tahoma" size="2"><b>From:</b> Daniel Sanders<br>
<b>Sent:</b> Friday, August 23, 2013 8:14 AM<br>
<b>To:</b> Jack Carter<br>
<b>Cc:</b> llvm-commits@cs.uiuc.edu<br>
<b>Subject:</b> RE: [PATCH] [mips][msa] Added bitconverts for vector types for big and little-endian<br>
</font><br>
</div>
<div></div>
<div>
<div class="WordSection1">
<p class="MsoNormal">I've found the problem. There are two ways to produce the SHF_B instruction. The first is via an intrinsic (INTRINSIC_W_CHAIN), the second is via a bitcast (when compiling for big-endian MSA). These two patterns disagree on whether the
OPFL_Chain flag should be set or not. TableGen is setting the OPFL_Chain flag which ultimately leads to an extra NULL operand being used when selecting code for the bitcast pattern.</p>
<p class="MsoNormal"> </p>
<p class="MsoNormal">When the "Few MSA Builtins have side-effects…" patch is also applied (which adds IntrNoMem to the intrinsic definition), both patterns agree that OPFL_Chain should not be set and the problem does not occur.</p>
<p class="MsoNormal"> </p>
<p class="MsoNormal">Sorry for not letting you know that the two patches were inter-dependant. Unfortunately I didn't realize that was the case. As we discussed offline, in future I'll specify a patch order to be on the safe side.</p>
<p class="MsoNormal"> </p>
<div style="border:none; border-left:solid blue 1.5pt; padding:0cm 0cm 0cm 4.0pt">
<div>
<div style="border:none; border-top:solid #B5C4DF 1.0pt; padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span style="font-size:10.0pt; font-family:"Tahoma","sans-serif"" lang="EN-US">From:</span></b><span style="font-size:10.0pt; font-family:"Tahoma","sans-serif"" lang="EN-US"> Daniel Sanders
<br>
<b>Sent:</b> 23 August 2013 12:57<br>
<b>To:</b> Jack Carter<br>
<b>Cc:</b> llvm-commits@cs.uiuc.edu<br>
<b>Subject:</b> RE: [PATCH] [mips][msa] Added bitconverts for vector types for big and little-endian</span></p>
</div>
</div>
<p class="MsoNormal"> </p>
<p class="MsoNormal">I haven't fully debugged it yet but it seems that another of my pending patches ([mips][msa] Few MSA Builtins have side-effects. Added IntrNoMem to those that don't) prevents the error.</p>
<p class="MsoNormal"> </p>
<div style="border:none; border-left:solid blue 1.5pt; padding:0cm 0cm 0cm 4.0pt">
<div>
<div style="border:none; border-top:solid #B5C4DF 1.0pt; padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span style="font-size:10.0pt; font-family:"Tahoma","sans-serif"" lang="EN-US">From:</span></b><span style="font-size:10.0pt; font-family:"Tahoma","sans-serif"" lang="EN-US"> Jack Carter
<br>
<b>Sent:</b> 22 August 2013 21:07<br>
<b>To:</b> Daniel Sanders<br>
<b>Cc:</b> llvm-commits@cs.uiuc.edu<br>
<b>Subject:</b> RE: [PATCH] [mips][msa] Added bitconverts for vector types for big and little-endian</span></p>
</div>
</div>
<p class="MsoNormal"> </p>
<div>
<p class="MsoNormal"><span style="font-size:10.0pt; font-family:"Tahoma","sans-serif"; color:black">Oops, I take that back.<br>
<br>
make check fails with the test case for me. <br>
<br>
Stack dump:<br>
0. Program arguments: /home/jcarter/workarea/assembler_jack/build/bin/./llc -march=mips -mattr=+msa
<br>
1. Running pass 'Function Pass Manager' on module '<stdin>'.<br>
2. Running pass 'MIPS DAG->DAG Pattern Instruction Selection' on function '@v16i8_to_v8i16'<br>
<br>
Failing Tests (1):<br>
LLVM :: CodeGen/Mips/msa/bitcast.ll<br>
<br>
Jack</span></p>
<div>
<div class="MsoNormal" style="text-align:center" align="center"><span style="font-size:12.0pt; font-family:"Times New Roman","serif"; color:black">
<hr align="center" size="2" width="100%">
</span></div>
<div id="divRpF304276">
<p class="MsoNormal" style="margin-bottom:12.0pt"><b><span style="font-size:10.0pt; font-family:"Tahoma","sans-serif"; color:black">From:</span></b><span style="font-size:10.0pt; font-family:"Tahoma","sans-serif"; color:black"> Jack Carter<br>
<b>Sent:</b> Thursday, August 22, 2013 1:00 PM<br>
<b>To:</b> Daniel Sanders<br>
<b>Cc:</b> llvm-commits@cs.uiuc.edu<br>
<b>Subject:</b> RE: [PATCH] [mips][msa] Added bitconverts for vector types for big and little-endian</span><span style="font-size:12.0pt; font-family:"Times New Roman","serif"; color:black"></span></p>
</div>
<div>
<div>
<p class="MsoNormal"><span style="font-size:10.0pt; font-family:"Tahoma","sans-serif"; color:black">LGTM,<br>
<br>
Jack</span></p>
<div>
<div class="MsoNormal" style="text-align:center" align="center"><span style="font-size:12.0pt; font-family:"Times New Roman","serif"; color:black">
<hr align="center" size="2" width="100%">
</span></div>
<div id="divRpF570159">
<p class="MsoNormal" style="margin-bottom:12.0pt"><b><span style="font-size:10.0pt; font-family:"Tahoma","sans-serif"; color:black">From:</span></b><span style="font-size:10.0pt; font-family:"Tahoma","sans-serif"; color:black"> Daniel Sanders<br>
<b>Sent:</b> Wednesday, August 21, 2013 6:47 AM<br>
<b>To:</b> Jack Carter<br>
<b>Cc:</b> llvm-commits@cs.uiuc.edu<br>
<b>Subject:</b> [PATCH] [mips][msa] Added bitconverts for vector types for big and little-endian</span><span style="font-size:12.0pt; font-family:"Times New Roman","serif"; color:black"></span></p>
</div>
<div>
<div>
<p class="MsoNormal"><span style="color:black"> </span></p>
<p class="MsoNormal"><span style="color:black"> </span></p>
<p class="MsoNormal" style="text-align:justify"><b><span style="font-size:12.0pt; font-family:"Arial","sans-serif"; color:#3333FF">Daniel Sanders</span></b><span style="color:black"></span></p>
<p class="MsoNormal" style="text-align:justify"><span style="font-size:10.0pt; font-family:"Arial","sans-serif"; color:#3333FF">Leading Software Design Engineer, MIPS Processor IP</span><span style="color:black"></span></p>
<p class="MsoNormal" style="text-align:justify"><span style="font-size:10.0pt; font-family:"Arial","sans-serif"; color:#3333FF">Imagination Technologies Limited</span><span style="color:black"></span></p>
<p class="MsoNormal" style="text-align:justify"><span style="color:black"><a href="http://www.imgtec.com/" target="_blank"><span style="font-size:10.0pt; font-family:"Arial","sans-serif"">www.imgtec.com</span></a></span></p>
<p class="MsoNormal"><span style="color:black"> </span></p>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</div>
</body>
</html>