<div dir="ltr">LGTM.</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Sun, Aug 18, 2013 at 2:44 PM, Saleem Abdulrasool <span dir="ltr"><<a href="mailto:compnerd@compnerd.org" target="_blank">compnerd@compnerd.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi ruiu,<br>
<br>
This adds additional missing Windows subsystem identifiers to the<br>
IMAGE_SUBSYSTEM enumeration.<br>
<br>
Signed-off-by: Saleem Abdulrasool <<a href="mailto:compnerd@compnerd.org">compnerd@compnerd.org</a>><br>
<br>
<br>
<a href="http://llvm-reviews.chandlerc.com/D1436" target="_blank">http://llvm-reviews.chandlerc.com/D1436</a><br>
<br>
Files:<br>
include/llvm/Support/COFF.h<br>
<br>
Index: include/llvm/Support/COFF.h<br>
===================================================================<br>
--- include/llvm/Support/COFF.h<br>
+++ include/llvm/Support/COFF.h<br>
@@ -511,7 +511,9 @@<br>
IMAGE_SUBSYSTEM_NATIVE = 1, ///< Device drivers and native Windows processes<br>
IMAGE_SUBSYSTEM_WINDOWS_GUI = 2, ///< The Windows GUI subsystem.<br>
IMAGE_SUBSYSTEM_WINDOWS_CUI = 3, ///< The Windows character subsystem.<br>
+ IMAGE_SUBSYSTEM_OS2_CUI = 5, ///< The OS/2 character subsytem.<br>
IMAGE_SUBSYSTEM_POSIX_CUI = 7, ///< The POSIX character subsystem.<br>
+ IMAGE_SUBSYSTEM_NATIVE_WINDOWS = 8, ///< Native Windows 9x driver.<br>
IMAGE_SUBSYSTEM_WINDOWS_CE_GUI = 9, ///< Windows CE.<br>
IMAGE_SUBSYSTEM_EFI_APPLICATION = 10, ///< An EFI application.<br>
IMAGE_SUBSYSTEM_EFI_BOOT_SERVICE_DRIVER = 11, ///< An EFI driver with boot<br>
@@ -519,7 +521,8 @@<br>
IMAGE_SUBSYSTEM_EFI_RUNTIME_DRIVER = 12, ///< An EFI driver with run-time<br>
/// services.<br>
IMAGE_SUBSYSTEM_EFI_ROM = 13, ///< An EFI ROM image.<br>
- IMAGE_SUBSYSTEM_XBOX = 14 ///< XBOX.<br>
+ IMAGE_SUBSYSTEM_XBOX = 14, ///< XBOX.<br>
+ IMAGE_SUBSYSTEM_WINDOWS_BOOT_APPLICATION = 16, ///< A BCD application.<br>
};<br>
<br>
enum DLLCharacteristics {<br>
</blockquote></div><br></div>