<div dir="ltr"><div>LGTM.<br><br></div>-Eli<br></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Sun, Aug 18, 2013 at 8:19 AM, Kuperstein, Michael M <span dir="ltr"><<a href="mailto:michael.m.kuperstein@intel.com" target="_blank">michael.m.kuperstein@intel.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div link="blue" vlink="purple" lang="EN-US">
<div>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">All of the Emit functions in BuildLibCalls.cpp use hardcoded names internally.
<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">I guess it’s a good idea to change all of that, but probably not in this commit.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">The reformatting was a mistake, it was needed in the broken version of the patch because I added a condition in the same if Op1C was defined in, changed it
back, thanks.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">(The comment reformatting is due to overlong lines)<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Does it look ok now?<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Michael<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Eli Friedman [mailto:<a href="mailto:eli.friedman@gmail.com" target="_blank">eli.friedman@gmail.com</a>]
<br>
<b>Sent:</b> Friday, August 16, 2013 01:18<br>
<b>To:</b> Kuperstein, Michael M<br>
<b>Cc:</b> <a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<b>Subject:</b> Re: [PATCH] Fix pow simplification when fabs and sqrt are unavailable<u></u><u></u></span></p><div><div class="h5">
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<div>
<p class="MsoNormal" style="line-height:115%">While you're here, you might as well fix the calls to EmitUnaryFloatFnCall to get the function name from TLI as well.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="line-height:115%"><u></u> <u></u></p>
</div>
<div>
<div>
<p class="MsoNormal" style="line-height:115%">- if (ConstantFP *Op1C = dyn_cast<ConstantFP>(Op1)) {<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="line-height:115%">+ ConstantFP *Op1C = dyn_cast<ConstantFP>(Op1);<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="line-height:115%">+ if (Op1C) {<u></u><u></u></p>
</div>
</div>
<div>
<p class="MsoNormal" style="line-height:115%"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal" style="line-height:115%">Why are you reformatting this?<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="line-height:115%"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal" style="line-height:115%">-Eli<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal" style="line-height:115%"><u></u> <u></u></p>
</div>
<p class="MsoNormal" style="line-height:115%"><u></u> <u></u></p>
<div>
<div>
<p class="MsoNormal" style="line-height:115%">On Thu, Aug 15, 2013 at 6:20 AM, Kuperstein, Michael M <<a href="mailto:michael.m.kuperstein@intel.com" target="_blank">michael.m.kuperstein@intel.com</a>> wrote:<u></u><u></u></p>
<div>
<div>
<p class="MsoNormal" style="line-height:115%">
<span style="color:#1f497d">Whoops, previous patch is bad.</span><u></u><u></u></p>
<p class="MsoNormal" style="line-height:115%">
<span style="color:#1f497d">Attached is a hopefully saner one.</span><u></u><u></u></p>
<p class="MsoNormal" style="line-height:115%">
<span style="color:#1f497d"> </span><u></u><u></u></p>
<p class="MsoNormal" style="line-height:115%">
<span style="color:#1f497d">(Also adds a missing check for pow(2.0, x) -> exp2(x) *<b>correctly*</b>, that’s unrelated to the ldexp issue.)</span><u></u><u></u></p>
<p class="MsoNormal" style="line-height:115%">
<span style="color:#1f497d"> </span><u></u><u></u></p>
<div>
<div style="border:none;border-top:solid #b5c4df 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Kuperstein, Michael M
<br>
<b>Sent:</b> Thursday, August 15, 2013 16:10<br>
<b>To:</b> <a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<b>Subject:</b> [PATCH] Fix pow simplification when fabs and sqrt are unavailable</span><u></u><u></u></p>
</div>
</div>
<div>
<div>
<p class="MsoNormal" style="line-height:115%">
<u></u><u></u></p>
<p class="MsoNormal" style="line-height:115%">
Hi,<u></u><u></u></p>
<p class="MsoNormal" style="line-height:115%">
<u></u><u></u></p>
<p class="MsoNormal" style="line-height:115%">
This adds a missing TLI check for the pow(x, 0.5) -> fabs(sqrt(x)) simplification.<u></u><u></u></p>
<p class="MsoNormal" style="line-height:115%">
<u></u><u></u></p>
<p class="MsoNormal" style="line-height:115%">
There’s a similar problem with exp2, but I don’t see a LibFunc::ldexp I can check for.
<u></u><u></u></p>
<p class="MsoNormal" style="line-height:115%">
Anyone has any idea if it’s missing on purpose, or just an omission? <u></u><u></u></p>
<p class="MsoNormal" style="line-height:115%">
<u></u><u></u></p>
<p class="MsoNormal" style="line-height:115%">
Michael<u></u><u></u></p>
</div>
</div>
</div>
<div>
<div>
<p>---------------------------------------------------------------------<br>
Intel Israel (74) Limited<u></u><u></u></p>
<p>This e-mail and any attachments may contain confidential material for<br>
the sole use of the intended recipient(s). Any review or distribution<br>
by others is strictly prohibited. If you are not the intended<br>
recipient, please contact the sender and delete all copies.<u></u><u></u></p>
</div>
</div>
</div>
<p class="MsoNormal" style="margin-bottom:12.0pt;line-height:115%"><br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><u></u><u></u></p>
</div>
<p class="MsoNormal" style="line-height:115%"><u></u> <u></u></p>
</div>
</div>
</div></div></div><div><div class="h5">
<p>---------------------------------------------------------------------<br>
Intel Israel (74) Limited</p>
<p>This e-mail and any attachments may contain confidential material for<br>
the sole use of the intended recipient(s). Any review or distribution<br>
by others is strictly prohibited. If you are not the intended<br>
recipient, please contact the sender and delete all copies.</p></div></div></div>
</blockquote></div><br></div>