<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Hi Tom,<div><br></div><div>LGTM.</div><div><br></div><div>Thanks,</div><div><br><div apple-content-edited="true">
<div style="color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">-Quentin</div>
</div>
<br><div><div>On Aug 14, 2013, at 5:39 PM, Tom Stellard <<a href="mailto:tom@stellard.net">tom@stellard.net</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">From: Tom Stellard <<a href="mailto:thomas.stellard@amd.com">thomas.stellard@amd.com</a>><br><br>---<br> lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp | 2 +-<br> test/CodeGen/R600/store.ll | 15 +++++++++++++++<br> 2 files changed, 16 insertions(+), 1 deletion(-)<br><br>diff --git a/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp b/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp<br>index 0637412..0406eb6 100644<br>--- a/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp<br>+++ b/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp<br>@@ -1268,7 +1268,7 @@ SDValue DAGTypeLegalizer::SplitVecOp_STORE(StoreSDNode *N, unsigned OpNo) {<br><br> // Increment the pointer to the other half.<br> Ptr = DAG.getNode(ISD::ADD, DL, Ptr.getValueType(), Ptr,<br>- DAG.getIntPtrConstant(IncrementSize));<br>+ DAG.getConstant(IncrementSize, Ptr.getValueType()));<br><br> if (isTruncating)<br> Hi = DAG.getTruncStore(Ch, DL, Hi, Ptr,<br>diff --git a/test/CodeGen/R600/store.ll b/test/CodeGen/R600/store.ll<br>index defbf91..365c292 100644<br>--- a/test/CodeGen/R600/store.ll<br>+++ b/test/CodeGen/R600/store.ll<br>@@ -230,6 +230,21 @@ entry:<br> ret void<br> }<br><br>+; EG-CHECK: @store_local_v4i8<br>+; EG-CHECK: LDS_WRITE<br>+; CM-CHECK: @store_local_v4i8<br>+; CM-CHECK: LDS_WRITE<br>+; SI-CHECK: @store_local_v4i8<br>+; SI-CHECK: DS_WRITE_B8<br>+; SI-CHECK: DS_WRITE_B8<br>+; SI-CHECK: DS_WRITE_B8<br>+; SI-CHECK: DS_WRITE_B8<br>+define void @store_local_v4i8(<4 x i8> addrspace(3)* %out, <4 x i8> %in) {<br>+entry:<br>+ store <4 x i8> %in, <4 x i8> addrspace(3)* %out<br>+ ret void<br>+}<br>+<br> ; EG-CHECK: @store_local_v2i32<br> ; EG-CHECK: LDS_WRITE<br> ; EG-CHECK: LDS_WRITE<br>-- <br>1.7.11.4<br><br>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits<br></blockquote></div><br></div></body></html>