<div dir="ltr">Do we have a test? <div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Aug 13, 2013 at 8:51 PM, Dmitry Vyukov <span dir="ltr"><<a href="mailto:dvyukov@google.com" target="_blank">dvyukov@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Author: dvyukov<br>
Date: Tue Aug 13 11:51:27 2013<br>
New Revision: 188291<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=188291&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=188291&view=rev</a><br>
Log:<br>
tsan: intercept getaddrinfo<br>
This is necessary to prevent false positives, see:<br>
<a href="https://code.google.com/p/thread-sanitizer/issues/detail?id=25" target="_blank">https://code.google.com/p/thread-sanitizer/issues/detail?id=25</a><br>
<br>
<br>
Modified:<br>
    compiler-rt/trunk/lib/tsan/rtl/tsan_interceptors.cc<br>
<br>
Modified: compiler-rt/trunk/lib/tsan/rtl/tsan_interceptors.cc<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/tsan/rtl/tsan_interceptors.cc?rev=188291&r1=188290&r2=188291&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/tsan/rtl/tsan_interceptors.cc?rev=188291&r1=188290&r2=188291&view=diff</a><br>

==============================================================================<br>
--- compiler-rt/trunk/lib/tsan/rtl/tsan_interceptors.cc (original)<br>
+++ compiler-rt/trunk/lib/tsan/rtl/tsan_interceptors.cc Tue Aug 13 11:51:27 2013<br>
@@ -1735,6 +1735,20 @@ TSAN_INTERCEPTOR(int, gettimeofday, void<br>
   return REAL(gettimeofday)(tv, tz);<br>
 }<br>
<br>
+TSAN_INTERCEPTOR(int, getaddrinfo, void *node, void *service,<br>
+    void *hints, void *rv) {<br>
+  SCOPED_TSAN_INTERCEPTOR(getaddrinfo, node, service, hints, rv);<br>
+  // We miss atomic synchronization in getaddrinfo,<br>
+  // and can report false race between malloc and free<br>
+  // inside of getaddrinfo. So ignore memory accesses.<br>
+  IgnoreCtl(thr, true, true);<br>
+  IgnoreCtl(thr, false, true);<br>
+  int res = REAL(getaddrinfo)(node, service, hints, rv);<br>
+  IgnoreCtl(thr, true, false);<br>
+  IgnoreCtl(thr, false, false);<br></blockquote><div><br></div><div>The combination of 8 bool values looks bad. </div><div>Can we have short names somewhere, like void IgnoreReadsBegin(thr) {IgnoreCtl(thr, false, true)} ? </div>
<div><br></div><div>-kcc </div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">

+  return res;<br>
+}<br>
+<br>
 // Linux kernel has a bug that leads to kernel deadlock if a process<br>
 // maps TBs of memory and then calls mlock().<br>
 static void MlockIsUnsupported() {<br>
@@ -2056,6 +2070,7 @@ void InitializeInterceptors() {<br>
   TSAN_INTERCEPT(usleep);<br>
   TSAN_INTERCEPT(nanosleep);<br>
   TSAN_INTERCEPT(gettimeofday);<br>
+  TSAN_INTERCEPT(getaddrinfo);<br>
<br>
   TSAN_INTERCEPT(mlock);<br>
   TSAN_INTERCEPT(munlock);<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div></div>