<html><head><meta http-equiv="Content-Type" content="text/html charset=iso-8859-1"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">r188300.<div><br></div><div>Michael</div><div><br><div><div>On Aug 13, 2013, at 10:26 AM, Lang Hames <<a href="mailto:lhames@gmail.com">lhames@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="font-family: Helvetica; font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><div dir="ltr">It might be worth adding a comment to explain what the tuple elements are. Something like:<div><br></div><div>/// makeLibCall - returns a pair of (return value, chain)</div><div><br></div><div>Other than that this looks good to me.</div><div><br></div><div>- Lang.</div><div><br></div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Aug 12, 2013 at 10:51 AM, Michael Gottesman<span class="Apple-converted-space"> </span><span dir="ltr"><<a href="mailto:mgottesman@apple.com" target="_blank">mgottesman@apple.com</a>></span><span class="Apple-converted-space"> </span>wrote:<br><blockquote class="gmail_quote" style="margin: 0px 0px 0px 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex;"><div style="word-wrap: break-word;">Ping.<div><br><div><div><div class="h5"><div>On Aug 9, 2013, at 1:16 PM, Michael Gottesman <<a href="mailto:mgottesman@apple.com" target="_blank">mgottesman@apple.com</a>> wrote:</div><br></div></div><blockquote type="cite"><div style="font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px;"><div><div class="h5">LowerCallTo returns a tuple consisting of the return SDValue of a call and the chain for the call. makeLibCall calls LowerCallTo but only returns the return SDValue. This means that any lib call without a return value can not be added into SelectionDAG since you are unable to get access to the chain of the call.<br><br>The attached patch fixes that issue by causing makeLibCall to return the tuple from LowerCallTo instead of just the first element. I additionally updated all calls to makeLibCall that use the current form to use the new from and updated two boolean options (doesNotReturn/isReturnValueUsed) that were hard coded as constant arguments to LowerCallTo in makeLibCall into two arguments to makeLibCall with default values set to the original hard coded constants.<br><br>Please review,<br>Michael<br><br></div></div><span><0001-Update-makeLibCall-to-return-both-the-call-and-the-c.patch></span>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a></div></blockquote></div><br></div></div><br>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a></blockquote></div></div></div></blockquote></div><br></div></body></html>