<div dir="ltr">I updated the file after this change, and we are now using std::map with the originalOffset as key. std::map is a sorted list so it's guaranteed that the map is sorted.</div><div class="gmail_extra"><br>

<br><div class="gmail_quote">On Mon, Aug 5, 2013 at 8:57 PM, Shankar Easwaran <span dir="ltr"><<a href="mailto:shankare@codeaurora.org" target="_blank">shankare@codeaurora.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

<br>
Thought this is a good assert, doesnt this work for all cases. Isnt this the fundamental model of splitting a section into multiple atoms too ?<div class="HOEnZb"><div class="h5"><br>
<br>
On 8/2/2013 2:10 PM, Rui Ueyama wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: ruiu<br>
Date: Fri Aug  2 14:10:29 2013<br>
New Revision: 187665<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=187665&view=rev" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project?rev=187665&view=rev</a><br>
Log:<br>
[PECOFF] Remove an assertion that's too heavy.<br>
<br>
Modified:<br>
     lld/trunk/lib/ReaderWriter/<u></u>PECOFF/ReaderCOFF.cpp<br>
<br>
Modified: lld/trunk/lib/ReaderWriter/<u></u>PECOFF/ReaderCOFF.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/PECOFF/ReaderCOFF.cpp?rev=187665&r1=187664&r2=187665&view=diff" target="_blank">http://llvm.org/viewvc/llvm-<u></u>project/lld/trunk/lib/<u></u>ReaderWriter/PECOFF/<u></u>ReaderCOFF.cpp?rev=187665&r1=<u></u>187664&r2=187665&view=diff</a><br>


==============================<u></u>==============================<u></u>==================<br>
--- lld/trunk/lib/ReaderWriter/<u></u>PECOFF/ReaderCOFF.cpp (original)<br>
+++ lld/trunk/lib/ReaderWriter/<u></u>PECOFF/ReaderCOFF.cpp Fri Aug  2 14:10:29 2013<br>
@@ -317,12 +317,6 @@ private:<br>
    COFFDefinedFileAtom *<br>
    findAtomAt(uint32_t targetOffset,<br>
               const vector<COFFDefinedFileAtom *> &atoms) const {<br>
-    assert(std::is_sorted(atoms.<u></u>begin(), atoms.end(),<br>
-                          [](const COFFDefinedFileAtom * a,<br>
-                             const COFFDefinedFileAtom * b) -> bool {<br>
-                            return a->originalOffset() < b->originalOffset();<br>
-                          }));<br>
-<br>
      for (COFFDefinedFileAtom *atom : atoms)<br>
        if (targetOffset < atom->originalOffset() + atom->size())<br>
          return atom;<br>
<br>
<br>
______________________________<u></u>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/llvm-commits</a><br>
<br>
<br>
</blockquote>
<br>
<br></div></div><span class="HOEnZb"><font color="#888888">
-- <br>
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation<br>
<br>
</font></span></blockquote></div><br></div>