<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">I also agree that returning false on
success is a pretty bad idea, stumbled over that a couple of
times, especially with AnalyzeBranch. <br>
<br>
Christian.<br>
<br>
Am 02.08.2013 15:30, schrieb Chad Rosier:<br>
</div>
<blockquote
cite="mid:CAMo3wbRo8Q6ncCk7c17mB=5XT5ep2f2omxqz0Pi1-cPyVArZkg@mail.gmail.com"
type="cite">+1 :)<br>
<br>
<div class="gmail_quote">On Thu, Aug 1, 2013 at 6:55 PM, Eric
Christopher <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:echristo@gmail.com" target="_blank">echristo@gmail.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
FWIW this drives me crazy as well.<br>
<span class="HOEnZb"><font color="#888888"><br>
-eric<br>
</font></span>
<div class="HOEnZb">
<div class="h5"><br>
On Thu, Aug 1, 2013 at 1:25 PM, Chandler Carruth <<a
moz-do-not-send="true"
href="mailto:chandlerc@google.com">chandlerc@google.com</a>>
wrote:<br>
> I have lobbied in the past for doing away with
returning false on success. I<br>
> continue to do so.<br>
><br>
> There are parts of the Clang parser that do this
consistently, but they are<br>
> increasingly few and far between. I consistently see
new code being written<br>
> in both Clang and LLVM using false to mean failure
and true to mean success,<br>
> so I think we should just admit that this is the
de-facto standard for new<br>
> code going forward.<br>
><br>
> That said, the last time I raised this question,
Chris showed up to argue.<br>
> ;]<br>
><br>
><br>
> On Thu, Aug 1, 2013 at 10:20 AM, Shuxin Yang <<a
moz-do-not-send="true"
href="mailto:shuxin.llvm@gmail.com">shuxin.llvm@gmail.com</a>>
wrote:<br>
>><br>
>> Hi, dear all:<br>
>><br>
>> I find some of the code (e.g.
LTOCodeGenerator) in llvm return false<br>
>> on succ (we might as well<br>
>> return 0 on succ as with many C code0); this is
very confusing,<br>
>> counter-intuitive, and error-prone.<br>
>> Things are even worse, if this piece of code call
other modules with<br>
>> negated logic.<br>
>><br>
>> In what situation should we use this negated
logic? Is it deprecated<br>
>> now? Can we toggle the logic<br>
>> to the way we would normally take for granted?<br>
>><br>
>> Thanks in advance!<br>
>> A senior newbie (just brazenly promote myself)<br>
>> _______________________________________________<br>
>> llvm-commits mailing list<br>
>> <a moz-do-not-send="true"
href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
>> <a moz-do-not-send="true"
href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits"
target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
><br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a moz-do-not-send="true"
href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> <a moz-do-not-send="true"
href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits"
target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
><br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a moz-do-not-send="true"
href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a moz-do-not-send="true"
href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits"
target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</div>
</div>
</blockquote>
</div>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
llvm-commits mailing list
<a class="moz-txt-link-abbreviated" href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a>
<a class="moz-txt-link-freetext" href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a>
</pre>
</blockquote>
<br>
</body>
</html>