<div dir="ltr">Thank you for reviewing. Addressed in r187673.<br></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Aug 2, 2013 at 1:56 PM, Nick Kledzik <span dir="ltr"><<a href="mailto:kledzik@apple.com" target="_blank">kledzik@apple.com</a>></span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im"><br>
On Aug 2, 2013, at 1:45 PM, Rui Ueyama <<a href="mailto:ruiu@google.com">ruiu@google.com</a>> wrote:<br>
<br>
> Author: ruiu<br>
> Date: Fri Aug  2 15:45:25 2013<br>
> New Revision: 187670<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=187670&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=187670&view=rev</a><br>
> Log:<br>
> Use report_fatal_error() instead of llvm_unreachable() to show broken input file error.<br>
><br>
> Modified:<br>
>    lld/trunk/lib/ReaderWriter/PECOFF/ReaderCOFF.cpp<br>
><br>
> Modified: lld/trunk/lib/ReaderWriter/PECOFF/ReaderCOFF.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/PECOFF/ReaderCOFF.cpp?rev=187670&r1=187669&r2=187670&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/PECOFF/ReaderCOFF.cpp?rev=187670&r1=187669&r2=187670&view=diff</a><br>


> ==============================================================================<br>
> --- lld/trunk/lib/ReaderWriter/PECOFF/ReaderCOFF.cpp (original)<br>
> +++ lld/trunk/lib/ReaderWriter/PECOFF/ReaderCOFF.cpp Fri Aug  2 15:45:25 2013<br>
> @@ -320,7 +320,7 @@ private:<br>
>     for (COFFDefinedFileAtom *atom : atoms)<br>
>       if (targetOffset < atom->originalOffset() + atom->size())<br>
>         return atom;<br>
> -    llvm_unreachable("Relocation target out of range");<br>
> +    llvm::report_fatal_error("Relocation target out of range");<br>
>   }<br>
<br>
</div>This really should return an error_code.  When lld is a library inside an app like an IDE, we don’t want to kill the whole app because of a malformed object file.<br>
<span class="HOEnZb"><font color="#888888"><br>
-Nick<br>
<br>
</font></span></blockquote></div><br></div>