<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Hi Rui,<br>
Thanks for the corrections, I've attached a new patch. For future
patches, I'll review the code style guide, which is very different
from what I'm used to. However, I have some doubts in a couple of
things.<br>
<br>
<blockquote type="cite">
<div><br>
</div>
<div>Looks like the entry function name should be _mainCRTStartup
if subsystem is "console",</div>
<div>_WinMainCRTStartup if subsystem is "windows", and
"__DllMainCRTStartup" for DLL.</div>
<div>See <a moz-do-not-send="true"
href="http://msdn.microsoft.com/en-us/library/f9t8842e%28v=vs.80%29.aspx">http://msdn.microsoft.com/en-us/library/f9t8842e(v=vs.80).aspx</a>.</div>
</blockquote>
I think this is rather a Visual Studio convention for its C runtime
library, and the PECOFF spec says nothing about it, so I though that
"_main" is a good default entry point name, taking into account that
there is currently no CRT guidelines (or at least I'm unaware of
them) in the lld project. In fact, this functions are defined in the
crtexe.c and crtdll.c files that you can find in \VC\crt\src
subfolder under your visual studio installation, and they handle all
the static initializations, collect the command line arguments, etc.
These files are silently linked to the image produced by LINK.EXE.
Summarizing, I though these names are tighly coupled to Visual
Studio build system, so I choose "_main" for simplicity and
generality.<br>
<br>
<blockquote type="cite">
<div><br>
</div>
<div>What about returning the address when success and return 0
when fail? Zero can never</div>
<div>be a valid virtual address so that should be safe.</div>
</blockquote>
PECOFF spec says that AddressOfEntryPoint could be zero in the case
of DLL images, so I've decided return a bool to take into account
this case. Nevertheless you are right and the virtual address of an
atom cannot be zero, so I've changed in the new patch.<br>
</body>
</html>