<div dir="ltr">Well now one is in. r187471</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Jul 30, 2013 at 6:45 PM, Richard Mitton <span dir="ltr"><<a href="mailto:richard@codersnotes.com" target="_blank">richard@codersnotes.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Yeah that makes sense, I just figured I'd wait to see if any of them actually made it in first :-)<span class="HOEnZb"><font color="#888888"><br>
<br>
Richard Mitton<br>
<a href="mailto:richard@codersnotes.com" target="_blank">richard@codersnotes.com</a></font></span><div class="HOEnZb"><div class="h5"><br>
<br>
On 07/30/2013 06:38 PM, Eric Christopher wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
If you're going to keep contributing then it seems reasonable at this<br>
point to ask for it as you've submitted a few good patches.<br>
<br>
-eric<br>
<br>
On Tue, Jul 30, 2013 at 6:35 PM, Richard Mitton <<a href="mailto:richard@codersnotes.com" target="_blank">richard@codersnotes.com</a>> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Nope.<br>
<br>
Richard Mitton<br>
<a href="mailto:richard@codersnotes.com" target="_blank">richard@codersnotes.com</a><br>
<br>
On 07/30/2013 06:33 PM, Craig Topper wrote:<br>
<br>
LGTM. Do you have commit access?<br>
<br>
<br>
On Tue, Jul 30, 2013 at 6:00 PM, Richard Mitton <<a href="mailto:richard@codersnotes.com" target="_blank">richard@codersnotes.com</a>><br>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Looks like my text editor randomly decided to change it's settings from<br>
spaces to tabs. Sorry, fixed now.<br>
<br>
<a href="http://llvm-reviews.chandlerc.com/D1241" target="_blank">http://llvm-reviews.chandlerc.<u></u>com/D1241</a><br>
<br>
CHANGE SINCE LAST DIFF<br>
<a href="http://llvm-reviews.chandlerc.com/D1241?vs=3088&id=3098#toc" target="_blank">http://llvm-reviews.chandlerc.<u></u>com/D1241?vs=3088&id=3098#toc</a><br>
<br>
Files:<br>
lib/Target/X86/X86InstrInfo.td<br>
<br>
Index: lib/Target/X86/X86InstrInfo.td<br>
==============================<u></u>==============================<u></u>=======<br>
--- lib/Target/X86/X86InstrInfo.td<br>
+++ lib/Target/X86/X86InstrInfo.td<br>
@@ -1079,16 +1079,16 @@<br>
"mov{b}\t{$src, %al|AL, $src}", [], IIC_MOV_MEM>,<br>
Requires<[In32BitMode]>;<br>
def MOV16o16a : Ii32 <0xA1, RawFrm, (outs), (ins offset16:$src),<br>
- "mov{w}\t{$src, %ax|AL, $src}", [], IIC_MOV_MEM>,<br>
OpSize,<br>
+ "mov{w}\t{$src, %ax|AX, $src}", [], IIC_MOV_MEM>,<br>
OpSize,<br>
Requires<[In32BitMode]>;<br>
def MOV32o32a : Ii32 <0xA1, RawFrm, (outs), (ins offset32:$src),<br>
"mov{l}\t{$src, %eax|EAX, $src}", [], IIC_MOV_MEM>,<br>
Requires<[In32BitMode]>;<br>
def MOV8ao8 : Ii32 <0xA2, RawFrm, (outs offset8:$dst), (ins),<br>
"mov{b}\t{%al, $dst|$dst, AL}", [], IIC_MOV_MEM>,<br>
Requires<[In32BitMode]>;<br>
def MOV16ao16 : Ii32 <0xA3, RawFrm, (outs offset16:$dst), (ins),<br>
- "mov{w}\t{%ax, $dst|$dst, AL}", [], IIC_MOV_MEM>,<br>
OpSize,<br>
+ "mov{w}\t{%ax, $dst|$dst, AX}", [], IIC_MOV_MEM>,<br>
OpSize,<br>
Requires<[In32BitMode]>;<br>
def MOV32ao32 : Ii32 <0xA3, RawFrm, (outs offset32:$dst), (ins),<br>
"mov{l}\t{%eax, $dst|$dst, EAX}", [], IIC_MOV_MEM>,<br>
<br>
______________________________<u></u>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/llvm-commits</a><br>
<br>
</blockquote>
<br>
<br>
--<br>
~Craig<br>
<br>
<br>
<br>
______________________________<u></u>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/llvm-commits</a><br>
<br>
</blockquote></blockquote>
<br>
______________________________<u></u>_________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/<u></u>mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br>~Craig
</div>