<div dir="ltr">I noticed the same thing so fixed in r<span style="font-family:arial,sans-serif;font-size:13px">186960.</span></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Jul 29, 2013 at 9:55 AM, Reid Kleckner <span dir="ltr"><<a href="mailto:rnk@google.com" target="_blank">rnk@google.com</a>></span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Does 0x400000U not work with EXPECT_EQ?</div><div class="HOEnZb"><div class="h5"><div class="gmail_extra">

<br><br><div class="gmail_quote">On Mon, Jul 22, 2013 at 3:21 PM, Rui Ueyama <span dir="ltr"><<a href="mailto:ruiu@google.com" target="_blank">ruiu@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: ruiu<br>
Date: Mon Jul 22 17:21:39 2013<br>
New Revision: 186884<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=186884&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=186884&view=rev</a><br>
Log:<br>
Fix -Wsign-compare warnings.<br>
<br>
Modified:<br>
    lld/trunk/unittests/DriverTests/WinLinkDriverTest.cpp<br>
<br>
Modified: lld/trunk/unittests/DriverTests/WinLinkDriverTest.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/unittests/DriverTests/WinLinkDriverTest.cpp?rev=186884&r1=186883&r2=186884&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/unittests/DriverTests/WinLinkDriverTest.cpp?rev=186884&r1=186883&r2=186884&view=diff</a><br>



==============================================================================<br>
--- lld/trunk/unittests/DriverTests/WinLinkDriverTest.cpp (original)<br>
+++ lld/trunk/unittests/DriverTests/WinLinkDriverTest.cpp Mon Jul 22 17:21:39 2013<br>
@@ -44,7 +44,7 @@ TEST_F(WinLinkParserTest, Basic) {<br>
   EXPECT_TRUE(_info.getInputSearchPaths().empty());<br>
   EXPECT_EQ(6, _info.getMinOSVersion().majorVersion);<br>
   EXPECT_EQ(0, _info.getMinOSVersion().minorVersion);<br>
-  EXPECT_EQ(0x400000, _info.getBaseAddress());<br>
+  EXPECT_EQ((uint64_t)0x400000, _info.getBaseAddress());<br>
   EXPECT_EQ(1024 * 1024ULL, _info.getStackReserve());<br>
   EXPECT_EQ(4096ULL, _info.getStackCommit());<br>
   EXPECT_FALSE(_info.allowRemainingUndefines());<br>
@@ -101,7 +101,7 @@ TEST_F(WinLinkParserTest, MinMajorMinorO<br>
<br>
 TEST_F(WinLinkParserTest, Base) {<br>
   EXPECT_FALSE(parse("link.exe", "-base", "8388608", "a.obj", nullptr));<br>
-  EXPECT_EQ(0x800000, _info.getBaseAddress());<br>
+  EXPECT_EQ((uint64_t)0x800000, _info.getBaseAddress());<br>
 }<br>
<br>
 TEST_F(WinLinkParserTest, StackReserve) {<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>