<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Thanks, committed in r<span style="font-family: Menlo; font-size: 11px;">187071.</span><div><font face="Menlo"><span style="font-size: 11px;"><br></span></font><div apple-content-edited="true">
<div style="color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">-Quentin</div>
</div>
<br><div><div>On Jul 24, 2013, at 11:31 AM, Jakob Stoklund Olesen <<a href="mailto:stoklund@2pi.dk">stoklund@2pi.dk</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;"><br>On Jul 11, 2013, at 4:39 PM, Quentin Colombet <<a href="mailto:qcolombet@apple.com">qcolombet@apple.com</a>> wrote:<br><br><blockquote type="cite">Hi,<br><br>Here is a patch that fixes a bug in IfConverter with nested predicates.<br><br>The problem seems so obvious that I am wondering if I am missing something.<br>So although the patch is straightforward (one line change), please review carefully.<br>Note: I have tested it with -O3 -arch armv7 (apple iOS) against both SingleSource and Multisource tests.<br><br>** Context **<br>Prior to this patch, IfConverter may widen the cases where a sequence of instructions were executed because of the way it uses nested predicates. This result in incorrect execution.<br><br>For instance, Let A be a basic block that flows conditionally into B and B be a predicated block.<br>B can be predicated with A.BrToBPredicate into A iff B.Predicate is less "permissive" than A.BrToBPredicate, i.e., iff A.BrToBPredicate subsumes B.Predicate.<br><br>The IfConverter was checking the opposite: B.Predicate subsumes A.BrToBPredicate.<br><br><<a href="rdar://problem/14379453">rdar://problem/14379453</a>><br><br>** Solution **<br>Check the ‘subsumes’ property correctly.<br><br>Thanks for your review.<br></blockquote><br>LGTM<br><br>Thanks,<br>/jakob</div></blockquote></div><br></div></body></html>