<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Adrian,<div><br></div><div>If you think you will need more time to fix the problem, please revert your patch.</div><div><br></div><div>Thanks,</div><div><br><div apple-content-edited="true">
<div style="color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">-Quentin</div>
</div>
<br><div><div>On Jul 9, 2013, at 4:18 PM, Adrian Prantl <<a href="mailto:aprantl@apple.com">aprantl@apple.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="font-size: 12px; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">I'm on it, thanks!<br><br>On Jul 9, 2013, at 4:13 PM, Quentin Colombet <<a href="mailto:qcolombet@apple.com">qcolombet@apple.com</a>> wrote:<br><br><blockquote type="cite">Hi Adrian,<br><br>Your commit breaks a buildbot:<br><a href="http://lab.llvm.org:8013/builders/clang-x86_64-darwin11-nobootstrap-RAincremental/builds/4150/">http://lab.llvm.org:8013/builders/clang-x86_64-darwin11-nobootstrap-RAincremental/builds/4150/</a><br>******************** TEST 'Clang :: debuginfo-tests/aggregate-indirect-arg.cpp' FAILED ********************<br>Script:<br>--<br>/Users/buildslave/zorg/buildbot/smooshlab/slave-0.8/build.clang-x86_64-darwin11-nobootstrap-RAincremental/clang-build/Release+Asserts/bin/clang -ccc-cxx -O0 -g /Users/buildslave/zorg/buildbot/smooshlab/slave-0.8/build.clang-x86_64-darwin11-nobootstrap-RAincremental/clang.src/test/debuginfo-tests/aggregate-indirect-arg.cpp -c -o /Users/buildslave/zorg/buildbot/smooshlab/slave-0.8/build.clang-x86_64-darwin11-nobootstrap-RAincremental/clang-build/tools/clang/test/debuginfo-tests/Output/aggregate-indirect-arg.cpp.tmp.o<br>/Users/buildslave/zorg/buildbot/smooshlab/slave-0.8/build.clang-x86_64-darwin11-nobootstrap-RAincremental/clang-build/Release+Asserts/bin/clang -ccc-cxx /Users/buildslave/zorg/buildbot/smooshlab/slave-0.8/build.clang-x86_64-darwin11-nobootstrap-RAincremental/clang-build/tools/clang/test/debuginfo-tests/Output/aggregate-indirect-arg.cpp.tmp.o -o /Users/buildslave/zorg/buildbot/smooshlab/slave-0.8/build.clang-x86_64-darwin11-nobootstrap-RAincremental/clang-build/tools/clang/test/debuginfo-tests/Output/aggregate-indirect-arg.cpp.tmp.out<br>/Users/buildslave/zorg/buildbot/smooshlab/slave-0.8/build.clang-x86_64-darwin11-nobootstrap-RAincremental/llvm/utils/test_debuginfo.pl /Users/buildslave/zorg/buildbot/smooshlab/slave-0.8/build.clang-x86_64-darwin11-nobootstrap-RAincremental/clang.src/test/debuginfo-tests/aggregate-indirect-arg.cpp /Users/buildslave/zorg/buildbot/smooshlab/slave-0.8/build.clang-x86_64-darwin11-nobootstrap-RAincremental/clang-build/tools/clang/test/debuginfo-tests/Output/aggregate-indirect-arg.cpp.tmp.out<br>--<br>Exit Code: 1<br>Command Output (stderr):<br>--<br>/Users/buildslave/zorg/buildbot/smooshlab/slave-0.8/build.clang-x86_64-darwin11-nobootstrap-RAincremental/clang.src/test/debuginfo-tests/aggregate-indirect-arg.cpp:8:11: error: expected string not found in input<br>// CHECK: $1 = {<br> ^<br>/Users/buildslave/zorg/buildbot/smooshlab/slave-0.8/build.clang-x86_64-darwin11-nobootstrap-RAincremental/clang-build/tools/clang/test/debuginfo-tests/Output/aggregate-indirect-arg.cpp.gdb.output:1:1: note: scanning from here<br>Reading symbols for shared libraries ... done<br>^<br>/Users/buildslave/zorg/buildbot/smooshlab/slave-0.8/build.clang-x86_64-darwin11-nobootstrap-RAincremental/clang-build/tools/clang/test/debuginfo-tests/Output/aggregate-indirect-arg.cpp.gdb.output:2:9: note: possible intended match here<br>Breakpoint 1 at 0x100000d5c: file /Users/buildslave/zorg/buildbot/smooshlab/slave-0.8/build.clang-x86_64-darwin11-nobootstrap-RAincremental/clang.src/test/debuginfo-tests/aggregate-indirect-arg.cpp, line 22.<br> ^<br>--<br><br>Could you have a look please?<br><br>Thanks,<br><br>-Quentin<br><br>On Jul 9, 2013, at 3:06 PM, Eric Christopher <echristo@gmail.com> wrote:<br><br><blockquote type="cite">On Tue, Jul 9, 2013 at 2:53 PM, Adrian Prantl <aprantl@apple.com> wrote:<br><blockquote type="cite">Hey Eric,<br><br>thanks for the comments!<br><br><br>On Jul 9, 2013, at 2:15 PM, Eric Christopher <echristo@gmail.com> wrote:<br><br><blockquote type="cite"><blockquote type="cite">bool LDVImpl::handleDebugValue(MachineInstr *MI, SlotIndex Idx) {<br>// DBG_VALUE loc, offset, variable<br>if (MI->getNumOperands() != 3 ||<br>- !MI->getOperand(1).isImm() || !MI->getOperand(2).isMetadata()) {<br>+ !(MI->getOperand(1).isReg() || MI->getOperand(1).isImm()) ||<br>+ !MI->getOperand(2).isMetadata()) {<br></blockquote><br>Mind commenting this a bit more on what we aren't handling?<br></blockquote><br>I’m not sure if I can come up with a comprehensive list of cases that are not handled. One case that I can think of would be a FrameIndex DBG_VALUE, but I’m not even sure whether they can even be introduced before LDV is run.<br><br></blockquote><br>Yeah, I'm not positive either. It just seemed odd like it's checking<br>for the validity of the instruction at all instead of some case that<br>it's not handling.<br><br><blockquote type="cite"><br><blockquote type="cite"><blockquote type="cite">- FuncInfo.ArgDbgValues.push_back(<br>+ FuncInfo.ArgDbgValues.push_back(BuildMI(MF, getCurDebugLoc(),<br>+ TII->get(TargetOpcode::DBG_VALUE),<br>+ /* IsIndirect */ Offset != 0,<br>+ Op->getReg(), Offset, Variable));<br><br></blockquote><br>Curious about the "Offset != 0" since we could have a 0 offset in the<br>dbg.value intrinsic coming in yes?<br></blockquote><br>I agree! I’m gradually pushing the problem up layer by layer. Currently this is just a more explicit notation of the status quo. I will add in a comment.<br><br></blockquote><br>Thanks :)<br><br>-eric<br><br>_______________________________________________<br>llvm-commits mailing list<br>llvm-commits@cs.uiuc.edu<br>http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</blockquote></blockquote></div></blockquote></div><br></div></body></html>