<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;">Checkout utils/git-svn/git-svnrevert. It will create the same sort of message, but will look up the svn commit revision and place it in instead of the git hash.<div><br></div><div>Michael</div><div><br><div><div>On Jul 8, 2013, at 11:29 AM, Eric Christopher <<a href="mailto:echristo@gmail.com">echristo@gmail.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="letter-spacing: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: auto; word-spacing: 0px; -webkit-text-stroke-width: 0px;">On Sun, Jul 7, 2013 at 6:30 PM, Nico Rieck <<a href="mailto:nico.rieck@gmail.com">nico.rieck@gmail.com</a>> wrote:<br><blockquote type="cite">Author: nrieck<br>Date: Sun Jul 7 20:30:57 2013<br>New Revision: 185781<br><br>URL:<span class="Apple-converted-space"> </span><a href="http://llvm.org/viewvc/llvm-project?rev=185781&view=rev">http://llvm.org/viewvc/llvm-project?rev=185781&view=rev</a><br>Log:<br>Revert "Reuse %rax after calling __chkstk on win64"<br><br>This reverts commit 01f8d579f7672872324208ac5bc4ac311e81b22e.<br><br></blockquote><br>Try to use svn revision numbers when you revert to keep the history clear.<br><br>Thanks!<br><br>-eric<br><br><blockquote type="cite">Modified:<br> llvm/trunk/lib/Target/X86/X86FrameLowering.cpp<br> llvm/trunk/lib/Target/X86/X86ISelLowering.cpp<br> llvm/trunk/test/CodeGen/X86/win64_alloca_dynalloca.ll<br><br>Modified: llvm/trunk/lib/Target/X86/X86FrameLowering.cpp<br>URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86FrameLowering.cpp?rev=185781&r1=185780&r2=185781&view=diff">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86FrameLowering.cpp?rev=185781&r1=185780&r2=185781&view=diff</a><br>==============================================================================<br>--- llvm/trunk/lib/Target/X86/X86FrameLowering.cpp (original)<br>+++ llvm/trunk/lib/Target/X86/X86FrameLowering.cpp Sun Jul 7 20:30:57 2013<br>@@ -914,14 +914,11 @@ void X86FrameLowering::emitPrologue(Mach<br> .addReg(X86::EFLAGS, RegState::Define | RegState::Implicit)<br> .setMIFlag(MachineInstr::FrameSetup);<br><br>- // MSVC x64's __chkstk does not adjust %rsp itself.<br>- // It also does not clobber %rax so we can reuse it when adjusting %rsp.<br>- if (isSPUpdateNeeded) {<br>- BuildMI(MBB, MBBI, DL, TII.get(X86::SUB64rr), StackPtr)<br>- .addReg(StackPtr)<br>- .addReg(X86::RAX)<br>- .setMIFlag(MachineInstr::FrameSetup);<br>- }<br>+ // MSVC x64's __chkstk needs to adjust %rsp.<br>+ // FIXME: %rax preserves the offset and should be available.<br>+ if (isSPUpdateNeeded)<br>+ emitSPUpdate(MBB, MBBI, StackPtr, -(int64_t)NumBytes, Is64Bit, IsLP64,<br>+ UseLEA, TII, *RegInfo);<br><br> if (isEAXAlive) {<br> // Restore EAX<br><br>Modified: llvm/trunk/lib/Target/X86/X86ISelLowering.cpp<br>URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp?rev=185781&r1=185780&r2=185781&view=diff">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp?rev=185781&r1=185780&r2=185781&view=diff</a><br>==============================================================================<br>--- llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (original)<br>+++ llvm/trunk/lib/Target/X86/X86ISelLowering.cpp Sun Jul 7 20:30:57 2013<br>@@ -14434,11 +14434,12 @@ X86TargetLowering::EmitLoweredWinAlloca(<br> } else {<br> // __chkstk(MSVCRT): does not update stack pointer.<br> // Clobbers R10, R11 and EFLAGS.<br>+ // FIXME: RAX(allocated size) might be reused and not killed.<br> BuildMI(*BB, MI, DL, TII->get(X86::W64ALLOCA))<br> .addExternalSymbol("__chkstk")<br> .addReg(X86::RAX, RegState::Implicit)<br> .addReg(X86::EFLAGS, RegState::Define | RegState::Implicit);<br>- // RAX has the offset to be subtracted from RSP.<br>+ // RAX has the offset to subtracted from RSP.<br> BuildMI(*BB, MI, DL, TII->get(X86::SUB64rr), X86::RSP)<br> .addReg(X86::RSP)<br> .addReg(X86::RAX);<br><br>Modified: llvm/trunk/test/CodeGen/X86/win64_alloca_dynalloca.ll<br>URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/win64_alloca_dynalloca.ll?rev=185781&r1=185780&r2=185781&view=diff">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/win64_alloca_dynalloca.ll?rev=185781&r1=185780&r2=185781&view=diff</a><br>==============================================================================<br>--- llvm/trunk/test/CodeGen/X86/win64_alloca_dynalloca.ll (original)<br>+++ llvm/trunk/test/CodeGen/X86/win64_alloca_dynalloca.ll Sun Jul 7 20:30:57 2013<br>@@ -19,7 +19,7 @@ entry:<br>; W64: movq %rsp, %rbp<br>; W64: $4096, %rax<br>; W64: callq __chkstk<br>-; W64: subq %rax, %rsp<br>+; W64: subq $4096, %rsp<br><br>; Freestanding<br>; EFI: movq %rsp, %rbp<br><br><br>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits<br></blockquote>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a></div></blockquote></div><br></div></body></html>